Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCI HelmRepo: handle status conditions in-line #748

Merged
merged 2 commits into from
May 31, 2022
Merged

OCI HelmRepo: handle status conditions in-line #748

merged 2 commits into from
May 31, 2022

Commits on May 30, 2022

  1. oci-helmrepo: handle conditions summary in-line 

    Refactor the OCI HelmRepo reconciler to remove extra custom status
conditions and manage Ready, Reconciling and Stalled conditions within
the reconciler, in-line.
The internal/reconcile/summarize package uses the patch helper
conditions summary before patching which results in overwriting the
Ready condition with Reconciling condition as it's a negative polarity
condition.
For OCI HelmRepository, since it's a simple reconciler, it'd be better
to not introduce extra conditions and utilize the three base conditions
to represent the status. In order to have the same consistent status
conditions, a new summarization is written within the reconciler based
on the context. It takes into consideration a lot of the details from
the internal/reconcile/summarize package and handles certain scenarios
in context specific ways. All the result and error abstractions are
removed since they are only needed when using internal/reconcile
package.

Signed-off-by: Sunny <darkowlzz@protonmail.com>
    @darkowlzz
    darkowlzz committed May 30, 2022
    Configuration menu
    Copy the full SHA
    d227586 View commit details
    Browse the repository at this point in the history

  2. helmrepo: rm stale condition when type switching 

    Remove stale condition from HelmRepo during garbage collection when a
type switch to OCI HelmRepo occurs. This ensures the OCI HelmRepo does
not have any conditions from the previous type.

Co-authored-by: Soule BA <soule@weave.works>
Signed-off-by: Sunny <darkowlzz@protonmail.com>
    @darkowlzz @souleb
    darkowlzz and souleb committed May 30, 2022
    Configuration menu
    Copy the full SHA
    9fe287d View commit details
    Browse the repository at this point in the history