libgit2: remove deadlock #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some scenarios may lead to deadlocks, specially in image automation controller. Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
pjbgf
requested review from
darkowlzz and
aryan9600
and removed request for
darkowlzz
darkowlzz
reviewed
Jun 16, 2022
| @@ -117,7 +122,6 @@ type connection struct { | |||
| session *ssh.Session | |||
| currentStream *sshSmartSubtransportStream | |||
| connected bool | |||
| m sync.RWMutex | |||
There was a problem hiding this comment.
I like this approach, no more locking and safer.
This whole connection type was created in order to group these variables and lock them together. Since we no longer lock with this change, we can put them back into sshSmartSubtransport struct.
There was a problem hiding this comment.
Pushed a commit with this change, as Paulo is away at the moment.
The connection type was created to group the connection related fields and use mutex to prevent race conditions. Since that's no longer the case, this puts back those fields in sshSmartSubtransport. Signed-off-by: Sunny <darkowlzz@protonmail.com>
hiddeco
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some scenarios may lead to deadlocks, specially in image automation controller.
Fix regression from #753 #775.