Update Azure Go SDK #786
Update Azure Go SDK #786
Conversation
phillebaba
force-pushed
the
update/azure-sdk
branch
from
41c68f9
to
d4ab975
Compare
|
See notes in fluxcd/flux2#2696 |
hiddeco
added
area/ci
|
@hiddeco always one step ahead. I was doing this work for the Thanos project so though why not just continue as the information was fresh in my head. |
|
@phillebaba please rebase with main where we have Go 1.18 |
phillebaba
force-pushed
the
update/azure-sdk
branch
2 times, most recently
from
fd1e121
to
663215d
Compare
Signed-off-by: Philip Laine <philip.laine@gmail.com>
stefanprodan
force-pushed
the
update/azure-sdk
branch
from
663215d
to
fdf6b01
Compare
|
@stefanprodan so I have had the same issues with CodeQL in the Thanos project. It also started happening when I updated the Azure SDK. I don't no if you immediately see what is wrong but I have spent some time trying to figure this out now without any luck. |
|
We can't merge this as the scanning is critical in our release workflow and this week we want to release OCI. |
Signed-off-by: Philip Laine <philip.laine@gmail.com>
|
@stefanprodan seems like the issue was not Azure SDK related but rather caused by CodeQL not using the correct Go version. Specifically setting the Go version has solved this issue. I found this issue which seems to cover the issue we are seeing. |
Updates Azure Go SDK to stable release.
This PR may have to wait as the stable release requires Go 1.18, not sure if that is a hard or soft requirement.