Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove custom reconcileID value from OCI HelmRepo logger and context overwrite #887

Merged
merged 2 commits into from
Sep 5, 2022
Merged

Remove custom reconcileID value from OCI HelmRepo logger and context overwrite #887

merged 2 commits into from
Sep 5, 2022

Commits on Sep 4, 2022

  1. Remove setting reconcileID in helmrepo-oci logger 

    With the new controller-runtime, the reconcileID is automatically set
per reconciliation and need not be set explicitly.

Signed-off-by: Sunny <darkowlzz@protonmail.com>
    @darkowlzz
    darkowlzz committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    658134f View commit details
    Browse the repository at this point in the history

  2. controllers: Remove ctx overwrite 

    Context in the reconcilers were overwritten earlier after adding new
log field `reconcileID` in the logger. Since the `reconcileID` is now
set by controller-runtime, this is no longer needed. The logger in the
context already has the field set and when the context is passed to
other functions, they too have the logger with the reconcileID set.

Signed-off-by: Sunny <darkowlzz@protonmail.com>
    @darkowlzz
    darkowlzz committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    59294bf View commit details
    Browse the repository at this point in the history