git: Fix issue with recurseSubmodules
#975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjbgf
added
bug
22 tasks
|
Can you please link to the PR in fluxcd/pkg that contains the actual fix. Have we added tests to make sure we don’t break the submodule feature in the future? |
|
@stefanprodan the issue was with the Flux specific FS, it wasn't clear that |
|
Hold the merge whilst we reassess the feedback from the user. |
pjbgf
force-pushed
the
fix-chroot
branch
2 times, most recently
from
6202ada
to
d24afcf
Compare
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
|
This has been confirmed to fix the linked issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Underlying fix: fluxcd/pkg#419.
Fixes #970.