Refactor aperture-go #2934
Merged
Refactor aperture-go #2934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor multiple files - Add protobuf files in gen/proto/flowcontrol dir - Add java proto gen files
|
Important Auto Review SkippedAuto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the TipsChat with CodeRabbit Bot (
|
tanveergill
reviewed
Nov 15, 2023
| @@ -63,16 +62,20 @@ func grpcOptions(insecureMode, skipVerify bool) []grpc.DialOption { | |||
| func main() { | |||
| ctx := context.Background() | |||
|
|
|||
| stdr.SetVerbosity(2) | |||
| apertureAgentAddr := getEnvOrDefault("APERTURE_AGENT_ADDRESS", defaultAgentAddress) | |||
There was a problem hiding this comment.
don't want to get anything through env. supposed to be provided explicitly by the developer. check typescript sdk
There was a problem hiding this comment.
This is example code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Checklist