fix: selection export dialog failing silently, code cleanup, #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upon pressing the selection export confirm button, the callback responsible for exporting only took a weak ref to the selected file. This in turn caused a race condition where the task executing the export raced against the dialog callback being finished, where the selected file is dropped, causing the weak ref upgrade to fail.
This was referenced Sep 20, 2024
Doublonmousse
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
I didn't realize that the selected_file was not going through the weak reference once more for the selection export whilst it wasn't part of the #[weak] variables for the other modes.
Hence with this the three modes are indeed identical (whereas I stopped midway).
Lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upon pressing the selection export confirm button, the callback responsible
for exporting only took a weak ref to the selected file.
This in turn caused a race condition where the task executing the export raced
against the dialog callback being finished, where the selected file is dropped,
causing the weak ref upgrade to fail.
fixes #1199, closes #1201