Added check for Vite app, opt to use Nginx instead of Node #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Try running |
- Checks if its a Vite app based on whether the "dev" script is defined as "vite" - Takes result of `vite build` from /dist and puts into Nginx's html directory
anniebabannie
force-pushed
the
annie/check-for-vite
branch
from
038eede to
ce1dd43
Compare
rubys
requested changes
Nov 21, 2023
Some other frameworks may also utilize Vite, in which cases we dont want to create the Dockerfile as a Vite app, but rather a <whatever framework> app instead.
|
@rubys Looking into the failing tests now... I'm not able to reproduce the failing tests locally, and I've rebased my branch on master just to make sure everything is up-to-date. |
rubys
approved these changes
Nov 21, 2023
|
@anniebabannie @rubys Will Remix + Vite be supported as well? |
|
@MichaelDeBoey Remix + Vite likely already works - full stack frameworks typically handle both the necessary build steps and the serving of static assets. If it doesn't work, let us know what the problem is and we'll fix it. What @anniebabannie added was support for front-end-only (which includes pure static) applications -- the build step is the same, but the deploy is nginx with no JS runtime installed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vite buildfrom /dist and puts into Nginx's html directory