Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Docker tag for postgres timescale variant to v16 #215

Closed
wants to merge 1 commit into from
Closed

Update Docker tag for postgres timescale variant to v16 #215

wants to merge 1 commit into from

Conversation

smorimoto
Copy link
Contributor

@smorimoto smorimoto commented Nov 14, 2023 •
edited
Loading

smorimoto
smorimoto commented Nov 14, 2023
View reviewed changes
Dockerfile-timescaledb Outdated
@@ -31,10 +30,10 @@ LABEL fly.pg-version=${PG_VERSION}
LABEL fly.pg-manager=repmgr

RUN apt-get update && apt-get install --no-install-recommends -y \
ca-certificates iproute2 postgresql-$PG_MAJOR_VERSION-repmgr curl bash dnsutils vim haproxy socat procps ssh gnupg rsync barman-cli barman barman-cli-cloud cron \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be installed in subsequent step, so no need to install it explicitly here.

@smorimoto smorimoto marked this pull request as ready for review December 2, 2023 22:13
@smorimoto
Copy link
Contributor Author

Okay, the timescale is ready to go!

@smorimoto smorimoto mentioned this pull request Dec 2, 2023
Closed
@smorimoto
Copy link
Contributor Author

Ref: https://packagecloud.io/timescale/timescaledb/packages/debian/bookworm/timescaledb-2-2.13.1-postgresql-16_2.13.1~debian12_amd64.deb

@JAForbes
Copy link

JAForbes commented Jan 25, 2024 •
edited
Loading

hey @smorimoto, how are you testing this? I tried creating a new pg, pushing the image to the app's registry, and running fly image update, but I can't seem to get a healthy instance. Wondering if I'm missing a crucial step.

I keep hitting issues with repmgr not being able to connect because of a version mismatch.

[NOTICE] repmgrd (repmgrd 5.4.1) starting up
[INFO] connecting to database "host=fdaa:0:78c0:a7b:233:51f3:5a9f:2 port=5433 user=repmgr dbname=repmgr connect_timeout=5"
[ERROR] an older version of the "repmgr" extension is installed
[DETAIL] extension version 5.3 is installed but newer version 5.4 is available
[HINT] verify the repmgr installation is updated properly before continuing

@JAForbes
Copy link

hey @smorimoto, how are you testing this? I tried creating a new pg, pushing the image to the app's registry, and running fly image update, but I can't seem to get a healthy instance. Wondering if I'm missing a crucial step.

I keep hitting issues with repmgr not being able to connect because of a version mismatch.

[NOTICE] repmgrd (repmgrd 5.4.1) starting up
[INFO] connecting to database "host=fdaa:0:78c0:a7b:233:51f3:5a9f:2 port=5433 user=repmgr dbname=repmgr connect_timeout=5"
[ERROR] an older version of the "repmgr" extension is installed
[DETAIL] extension version 5.3 is installed but newer version 5.4 is available
[HINT] verify the repmgr installation is updated properly before continuing

Update: It works if I push to docker hub and create a fresh postgres and avoid image update.

@davissp14
Copy link
Contributor

Repmgr 5.4.1 is getting installed automatically with the new image build. I updated the base image to pin the repmgr version, but we may need to migrate to 5.4.1 for PG 16. The latest version of repmgr should work fine with PG15, but the upgrade path needs more testing.

@JAForbes
Copy link

JAForbes commented Mar 3, 2024

What would the very rough ETA be on the release given it needs more testing? Just on the fence about using the new timescale syntax (not currently supported with fly's TS version) for some work or holding off.

@smorimoto
Update Docker tag for postgres timescale variant to v16
fa58db1 
Signed-off-by: Sora Morimoto <sora@morimoto.io>
@smorimoto
Copy link
Contributor Author

Rebased to latest master.

@davissp14
Copy link
Contributor

Closing in favor of: #233

@davissp14 davissp14 closed this Jul 6, 2024
@smorimoto smorimoto deleted the pg-16-timescale branch July 8, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JAForbes JAForbes JAForbes left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smorimoto @JAForbes @davissp14