Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing LF to last line in config/haproxy.cfg #97

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Add missing LF to last line in config/haproxy.cfg #97

merged 1 commit into from
Jan 11, 2023

Conversation

tosie
Copy link
Contributor

@tosie tosie commented Jan 11, 2023

When reading the logs of one of our DB clusted I noticed this line:

[WARNING] 010/124751 (538) : parsing [/fly/haproxy.cfg:38]: Missing LF on last line, file might have been truncated at position 96. This will become a hard error in HAProxy 2.3.

Since a missing LF is easy to add, here it is.

@tosie
Add missing LF to last line in config/haproxy.cfg
ce94a3f 
A missing LF in the last line is currently a warning, but will become a hard error with HAProxy 2.3.
davissp14
davissp14 approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@davissp14 davissp14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@davissp14 davissp14 merged commit 559cfcc into fly-apps:main Jan 11, 2023
@tosie tosie deleted the add-lf-to-haproxy-config branch January 11, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davissp14 davissp14 davissp14 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tosie @davissp14