fix: engines not starting properly in msfs 2024

[Saschl]

Fixes #9575

Summary of Changes

execute_calculator_code does not seem to work properly in this case (and is discouraged anyway). Replaced with trigger_key_event (deprecated but working in both sims), which brings the correct behaviour back again.

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

1. Spawn C&D in both sims ideally and perform engine starts with APU and ASU. N2 should rise quickly after engine master switches have been turned on

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

1. Make sure you are signed in to GitHub
2. Click on the Checks tab on the PR
3. On the left side, find and click on the PR Build tab
4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

[tracernz]

No changelog needed as there's no user-visible change.

[flogross89]

Does this only apply to Rust code or also to C++ code? execute_calculator_code is used extensively there

[Saschl]

Does this only apply to Rust code or also to C++ code? execute_calculator_code is used extensively there

Will need to check that as well 👍 Most of the calls do not seem to take parameters which seems to work fine, but I haven't checked very thoroughly yet

[MJ-AmJay]

Quality Assurance Trainee Report

Discord Username : notwong0639
Object of testing : #9583
Aircraft : A32NX_FS2024
Tier of Testing : 1
Date : 26/11/2024

Testing Process:
Perform the standard engine start procedure as outlined in the official FlyByWire (FBW) documentation from cold & dark.
Observe the engine behavior during the startup phase.

Testing Results:
Passed

Negatives:
N/A

Conclusions:
The reported bug regarding the engine startup behavior, where N2% takes an unexpectedly long time to spool up, engines shut down automatically during the start phase, and EGT values remain elevated, has been thoroughly addressed. The issue has been confirmed as fixed. The engines now start as expected, aligning with the standard performance outlined in the official FlyByWire (FBW) documentation.

Media:
https://youtu.be/phzqLbosxsY