Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: engines not starting properly in msfs 2024 #9583

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Saschl
Copy link
Contributor

@Saschl Saschl commented Nov 24, 2024

Fixes #[issue_no]

Summary of Changes

execute_calculator_code does not seem to work properly in this case (and is discouraged anyway). Replaced with trigger_key_event (deprecated but working in both sims), which brings the correct behaviour back again.

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

  1. Spawn C&D in both sims ideally and perform engine starts with APU and ASU. N2 should rise quickly after engine master switches have been turned on

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@Saschl Saschl added QA Tier 1 MSFS2024 PRs Fixing FS2024 Issues labels Nov 24, 2024
@tracernz
Copy link
Member

No changelog needed as there's no user-visible change.

@flogross89
Copy link
Contributor

Does this only apply to Rust code or also to C++ code? execute_calculator_code is used extensively there

@Saschl
Copy link
Contributor Author

Saschl commented Nov 24, 2024

Does this only apply to Rust code or also to C++ code? execute_calculator_code is used extensively there

Will need to check that as well 👍 Most of the calls do not seem to take parameters which seems to work fine, but I haven't checked very thoroughly yet

Comment on lines +111 to +113
let action: u32 = if on { 1 } else { 0 };

trigger_key_event(KEY_APU_BLEED_AIR_SOURCE_SET, action);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
let action: u32 = if on { 1 } else { 0 };
trigger_key_event(KEY_APU_BLEED_AIR_SOURCE_SET, action);
trigger_key_event(KEY_APU_BLEED_AIR_SOURCE_SET, on.into());

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MSFS2024 PRs Fixing FS2024 Issues QA Tier 1
Projects
Status: 🔴 Code Review: In progress
Development

Successfully merging this pull request may close these issues.

4 participants