-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(build/efb): aircraft project prefix overhaul to better support different a/c and variants (v0.1) #8599
Conversation
fixes 8499 add simvar description fix simvar docs
fix fix fix port-back fix fix
…nx' to use environ
4493238
to
9f4e119
Compare
6ed52dd
to
0c91ebd
Compare
0c91ebd
to
c71a702
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - a bit more documentation would have been nice ;)
fbw-a32nx/src/base/flybywire-aircraft-a320-neo/config/a32nx/a320-251n/README.md
Outdated
Show resolved
Hide resolved
fbw-a32nx/src/base/flybywire-aircraft-a320-neo/config/a32nx/a320-251n/README.md
Outdated
Show resolved
Hide resolved
fbw-a32nx/src/base/flybywire-aircraft-a320-neo/config/a32nx/a320-251n/README.md
Outdated
Show resolved
Hide resolved
fbw-a32nx/src/base/flybywire-aircraft-a320-neo/config/a32nx/a320-251n/README.md
Outdated
Show resolved
Hide resolved
fbw-a380x/src/base/flybywire-aircraft-a380-842/config/a380x/a380-842/README.md
Show resolved
Hide resolved
fbw-a380x/src/base/flybywire-aircraft-a380-842/config/a380x/a380-842/README.md
Outdated
Show resolved
Hide resolved
fbw-common/src/systems/instruments/src/EFB/Apis/Simbrief/simbriefParser.ts
Show resolved
Hide resolved
Yes, earmarked for v0.2 when I've gotten a better handle on the functional requirements and what boilerplate, middleware, etc is needed, as well as that commbus link with WASM. |
Quality Assurance Trainee Report Discord : noonebling Testing Process: Negatives: Testing Results: Conclusions: |
As this could create merge conflicts with fms-v2, I'll hold off on merging until that is merged. |
QA pass label removed to let more QA trainees be able to run through this one while we wait for some large PR merges. |
Partially Addresses #7665
Fixes #8499
Summary of Changes
Based on #8500 we will start to transition away from a panel.cfg/L:Var based approach towards a markup .json and build time based approach to handling multiple A/C, variants as well as liveries (by ATC tail registration)
This will ensure that the aircraft prefix is correctly set (not dependant on livery), as proposed by #8500, as well as allowing for easier flyPad configuration, management and changes in the future.
This modifies:
flyPad OS (3.2.1)
Ground > Payload
Ground > Services
Ground > Fuel
Ground > Pushback
Checklists
Dispatch > Overview
Settings > Throttle Config
Settings > About
Clean up fbw-aXX > fbw-common EFB refactor
Potential:
FBW Api - Add "title" and "aircraft" to FBW api requestNot doneExtras-host
Override with VFS/{aircraft}/{variant}/{atc_id} json5(not in this PR)This also adds a new
AIRCRAFT_PROJECT_PREFIX
environ to the project.env
which is mandatory.Note:
AIRCRAFT_VARIANT
has been added, but in the future this will be created with the script/*.sh scripts.Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub): 2cas
Testing instructions
Test all the following EFB pages, ensure functionality is as expected.
Checklists
Dispatch > Overview
Settings > Throttle Config
Settings > About
General
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.