Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nws): add better NWS hacks #8606

Merged
merged 3 commits into from
Apr 7, 2024

Conversation

lukecologne
Copy link
Member

@lukecologne lukecologne commented Apr 3, 2024

Summary of Changes

This PR fixes two things related to the NWS:

  • Enables the sim NWS to move when standing still (was previously only possible visually, but not functionally)
  • Enhance the previous hack required to cancel out the rudder effect on the NWS, by limiting the NWS amplitude to the commanded value. This removes jittering that happens when the rudder is moved.

NOTE: There is still the issue that when giving opposite rudder and tiller orders, the sim's NWS command due to the rudder deflection can only be cancelled, but the NWS doesn't steer in the tiller direction as it should. AFAIK. there is nothing we can do about that.

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

Confirm that

  • There is no more slight oscillation in the taxi path when using the rudder (very noticeable when using pedal disc, but also happens when using the rudder pedals to command the NWS)
  • The NWS turns at a standstill (not only visually, which it did before, but also functionally)
  • The NWS otherwise works correctly (except the note above)

This was changed both on the 380 and the 320.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on either flybywire-aircraft-a320-neo or flybywire-aircraft-a380-842 download link at the bottom of the page

@2hwk
Copy link
Member

2hwk commented Apr 4, 2024

No changelog.md required, covered by line 49 from 0.11.0 -> 0.12.0.

@lukecologne testing instructions pending

@2hwk 2hwk added Not Ready For Testing Not ready for testing as still being discussed or developed. QA Tier 1 labels Apr 4, 2024
@Saschl Saschl removed the Not Ready For Testing Not ready for testing as still being discussed or developed. label Apr 5, 2024
@aguther
Copy link
Contributor

aguther commented Apr 6, 2024

There is no doubt that this PR is a good improvement, and the situation is better after the merge than before.

For the sake of completeness, however, it should be said that it does not completely solve the problems. There is still a certain amount of jerkiness when changing the rudder deflection from left to right or vice versa. This is particularly noticeable when using VR.

I guess this can only be solved when Microsoft allows to completely remove the connection between rudder and nosewheel.

@noonebling
Copy link

Quality Assurance Trainee Report

Discord : noonebling
Object of testing: 8606
Tier of Testing : 1
Date : 07/04/2024

Testing Process:

  1. Started flight with default joystick setup
  2. Tested NWS at a standstill to check the functional
  3. No more slight oscillation in the taxi path

Negatives:
N/A

Testing Results:
Passed

Conclusions:
Works as expected

@2hwk 2hwk removed the QA Passed label Apr 7, 2024
@aguther aguther merged commit 7b7e42b into flybywiresim:master Apr 7, 2024
7 checks passed
@2hwk 2hwk added this to the v0.12.0 milestone Apr 10, 2024
@lukecologne lukecologne deleted the better-nws-hack branch April 11, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

5 participants