chore: cpp framework improvements and additions #8640

frankkopp · 2024-04-30T17:06:54Z

Summary of Changes

General additions and improvements to the cpp framework.

added arinc library
added Google Test GTest framework
added unit tests for cpp libraries
refactored InterialDampener to a general DampingController
additional clang format to better align code for multiple assignment statements
gitignore cleanup

Discord username (if different from GitHub): cdr_maverick

Testing instructions

Potentially Pushback, Lighting Presets, Aircraft Presets might be impacted by these changes.
Mainly Pushback (b/o the DampingController refactor).
Other side effects unlikely.

A32NX: see above - test for regression
A380X: see above - test for regression

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

Make sure you are signed in to GitHub
Click on the Checks tab on the PR
On the left side, find and click on the PR Build tab
Click on either flybywire-aircraft-a320-neo or flybywire-aircraft-a380-842 download link at the bottom of the page

fbw-a32nx/src/wasm/extra-backend-a32nx/src/Gauge_Extra_Backend.cpp

package.json

2hwk · 2024-05-03T03:02:41Z

Just some early comments, looking good so far.

Popespice · 2024-08-22T00:57:31Z

Quality Assurance Tester Report

Discord : popespice
Object of testing: 8640
Tier of Testing : 2
Date : 21/8/2024

Testing Process:

Start sim as usual
Load into A32NX
Power up plane as normal
Individually select different presets (lighting and aircraft)
Taxi aircraft through built in taxi mechanism in EFB
Observe all presets work, aircraft flies as expected.

Negatives:
N/A
Testing Results:
Passed
Conclusions:
Working as expected.

tylerclt · 2024-08-22T15:32:41Z

Quality Assurance Trainee Report

Discord: Tylerb780#3594
Object of testing: #8640
Tier of Testing: 2
Date: 22/08/2024)

Testing Process:

Loaded into the Aircraft
Powered-up aircraft as normal
Went through each individual lighting and aircraft preset
Pushed using the built-in pushback system
Made sure aircraft flew with no issues or abnormalities

Negatives:
N/A

Testing Results:
Passed

Conclusions:
Working as intended

Maximilian-Reuter · 2024-08-23T15:44:39Z

fbw-a380x/src/wasm/fadec_a380x/src/Fadec/Table1502_A380X.hpp

@@ -30,23 +30,22 @@ class Table1502_A380X {
   * @return A 2D array representing the CN2 - correctedN1 pairs.
   */
  static constexpr double table1502[13][4] = {


The values in the comments here dont reflect the table values and seem copied from the a32nx

see above - did not touch the values

Maximilian-Reuter · 2024-08-23T15:45:28Z

fbw-a380x/src/wasm/fadec_a380x/src/Fadec/ThrustLimits_A380X.hpp

+      {15000,   8.000,   24.000,  95.686, 89.907, 58.723}, //
+      {16000,   5.000,   22.000,  96.160, 89.816, 57.189}, //
+      {16600,   5.000,   22.000,  96.560, 89.816, 57.189}, //
+      {-2000,   47.751,  54.681,  84.117, 81.901, 63.498}, // row 20


this line seems to belong to the GA part of the table and not the TO part

this line seems to belong to the GA part of the table and not the TO part

I did not touch the values (at least not on purpose) - these should be the same as before (from the FADEC rewrite where I also did not touch values.

The changes to this file are only formatting in this PR.

I know I didnt mean to imply it had, just that this is smth that I noticed recently so wondered if you maybe want to quickly change that

Ah ok - no problem. If you want you can also just push to the PR. I'm on vacation with no PC.

pilotseyea350 · 2024-08-23T16:49:56Z

Quality Assurance Trainee Report

Discord: piloteyesA350
Object of testing: #8640
Tier of Testing: 2
Date: 23/08/2024

Testing Process:

Aircraft Loaded at EDDM
Power Up using Aircraft States
Set different cockpit lights configuration and save them
Pushback using the EFB Pushback
Fly from EDDM to EDDS
Monitor systems
Have fun
Negatives:
"Ready to pushback" state completion is reliant on ADIRS alignment time which, if set to Real, does not happen until either ADIRS Alignment time is set to "Instant" or ADIRS is aligned. Known Issue but Fast Loading should override EFB Realism settings
As discussed in QA Channel, Transition from "Ready to Pushback" to "Ready To Taxi" triggers Master Warning & Master Caution due to Flaps and Slats not being in TO Position
Saving a lightning preset and not renaming it prevents it from being used as an automatic loaded Lightning preset. We could also change the Default names of the presets to "No Name 1" for preset 1, "No Name 2" for preset 2, etc...
CKPT, FWD CAB & AFT CAB DUCT OVHT ( Ecam message after switching from an Engines running preset to a engines non running preset)

Testing Results:
Not Passed

Conclusions:
ADIRS Issue was known but Master Caution & Master Warning is not expected.

N. B. :
#8581
https://streamable.com/vkq57o

frankkopp · 2024-08-27T13:32:02Z

Negatives:

"Ready to pushback" state completion is reliant on ADIRS alignment time which, if set to Real, does not happen until either ADIRS Alignment time is set to "Instant" or ADIRS is aligned. Known Issue but Fast Loading should override EFB Realism settings

This is known and intendent for the current implementation - it is improved in #8581 as it required system internal changes.

As discussed in QA Channel, Transition from "Ready to Pushback" to "Ready To Taxi" triggers Master Warning & Master Caution due to Flaps and Slats not being in TO Position

Not an issue caused by this PR (already known issue) - but workaround has been put in place.
Please retest this workaround (it basically waits until the Flaps/Slats are deployed before pressing T.O CONFIG)

This is improved/fixed in #8581 as it required system internal changes.

Saving a lightning preset and not renaming it prevents it from being used as an automatic loaded Lightning preset. We could also change the Default names of the presets to "No Name 1" for preset 1, "No Name 2" for preset 2, etc...

How is this prevented? Could not reproduce it.
(Likely also outside this PR)

CKPT, FWD CAB & AFT CAB DUCT OVHT ( Ecam message after switching from an Engines running preset to a engines non running preset)

Could not be reproduced - please re-test with latest PR build.

Testing Results: Not Passed

Conclusions: ADIRS Issue was known but Master Caution & Master Warning is not expected.

pilotseyea350 · 2024-09-09T17:04:03Z

I'll try again this afternoon with the latest build

pilotseyea350 · 2024-09-10T04:31:50Z

Just tested it and it did work with the auto-preset off. Will do a T2 asap to alow you to merge

pilotseyea350 · 2024-09-12T03:33:28Z

Is the vertical profile green dot below the selected altitude expected ?

frankkopp · 2024-09-12T07:28:28Z

Is the vertical profile green dot below the selected altitude expected ?

The cpp code of this PR does not touch any of this. Its really only used in the backend (not front end / UI) for Lighting Preset, Aircraft Preset, pushback, FADEC.
Frontend is in Typescript which is why the Automatic Lighting presets is also not touched as this logic is TS only.

tracernz · 2024-09-12T08:09:59Z

And it's also perfectly fine, so no issue 👍 . The vertical profile doesn't take into account the selected altitude.

pilotseyea350 · 2024-09-12T12:46:15Z

Quality Assurance Trainee Report

Discord Username : PilotEyesA350
Object of testing : #8640
Aircraft : A32NX
Tier of Testing : 2
Date : 11/09/2024

Testing Process:

Load aircraft at gate
Follow A320 flows
Fly from EDDF to EDDF using a Simbrief Flightplan
Monitor systems

Testing Results:
Passed

Negatives:
N/A

Conclusions:
After much work it finally works as intended !

Media:
N/A

frankkopp · 2024-09-13T08:40:27Z

Quality Assurance Trainee Report

Discord Username : PilotEyesA350 Object of testing : #8640 Aircraft : A32NX Tier of Testing : 2 Date : 11/09/2024

Testing Process:

Load aircraft at gate

Follow A320 flows

Fly from EDDF to EDDF using a Simbrief Flightplan

Monitor systems

Testing Results: Passed

Negatives: N/A

Conclusions: After much work it finally works as intended !

Media: N/A

Thanks - your effort is very much appreciated!!

…yed.

frankkopp self-assigned this Apr 30, 2024

frankkopp added the Not Ready For Review Still draft but needs a GitHub build label Apr 30, 2024

frankkopp marked this pull request as ready for review April 30, 2024 17:09

2hwk requested changes May 3, 2024

View reviewed changes

fbw-a32nx/src/wasm/extra-backend-a32nx/src/Gauge_Extra_Backend.cpp Show resolved Hide resolved

package.json Show resolved Hide resolved

frankkopp added Needs Code Review and removed Not Ready For Review Still draft but needs a GitHub build labels May 9, 2024

frankkopp force-pushed the cpp-framework-improvements branch from c63899c to 7ae8c6b Compare May 29, 2024 14:17

frankkopp force-pushed the cpp-framework-improvements branch from 7ae8c6b to 8a3e94a Compare June 14, 2024 17:43

2hwk approved these changes Jul 28, 2024

View reviewed changes

alepouna added QA Tier 2 QA Ready to Test and removed Needs Code Review labels Aug 20, 2024

github-actions bot added the QA Passed label Aug 22, 2024

Maximilian-Reuter reviewed Aug 23, 2024

View reviewed changes

github-actions bot added QA Failed and removed QA Passed labels Aug 23, 2024

frankkopp force-pushed the cpp-framework-improvements branch 2 times, most recently from e25e357 to 8791046 Compare August 27, 2024 11:52

frankkopp removed the QA Failed label Aug 30, 2024

frankkopp force-pushed the cpp-framework-improvements branch from 5ec30c7 to 3b27d13 Compare August 30, 2024 11:59

frankkopp force-pushed the cpp-framework-improvements branch from bdf6c56 to bb193a1 Compare September 9, 2024 16:41

github-actions bot added QA Passed and removed QA Failed QA Ready to Test labels Sep 12, 2024

frankkopp added 15 commits September 13, 2024 10:41

Added getDataDefinitionVarByName to DataManager

5f29321

Cleanup, formatting and commenting

256d41a

Added additional libs and functions

d4bba54

Added GTest framework and some initial tests

f2d6748

Added arinc library and initial unit tests

5434915

Added arinc library and initial unit tests

4574448

Refactored test folders and move dampener class to lib

fcfd58e

Improved clang-format to align assignment expressions

3192e86

Code documentation

429bdd1

Removed unnecessary include definition

301e1bb

Code documentation

52ec950

Improved handling of aircraft prefix

0ef634b

removed old comment

e3225e1

Code reformatting

5ea2d5c

Fix Master Alarm when pressing T.O CONFIG when Flaps or not yet deplo…

13c5ed2

…yed.

frankkopp force-pushed the cpp-framework-improvements branch from bb193a1 to 13c5ed2 Compare September 13, 2024 08:41

frankkopp merged commit c4ab989 into flybywiresim:master Sep 13, 2024
7 checks passed

frankkopp deleted the cpp-framework-improvements branch September 13, 2024 09:58

lukecologne mentioned this pull request Sep 15, 2024

chore: add NOMINMAX to fbw, revert clang-format change for fbw #8925

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: cpp framework improvements and additions #8640

chore: cpp framework improvements and additions #8640

frankkopp commented Apr 30, 2024 •

edited

Loading

2hwk commented May 3, 2024

Popespice commented Aug 22, 2024

tylerclt commented Aug 22, 2024

Maximilian-Reuter Aug 23, 2024

frankkopp Aug 23, 2024

Maximilian-Reuter Aug 23, 2024

frankkopp Aug 23, 2024

Maximilian-Reuter Aug 24, 2024

frankkopp Aug 24, 2024

pilotseyea350 commented Aug 23, 2024

frankkopp commented Aug 27, 2024

pilotseyea350 commented Sep 9, 2024

pilotseyea350 commented Sep 10, 2024 •

edited

Loading

pilotseyea350 commented Sep 12, 2024

frankkopp commented Sep 12, 2024

tracernz commented Sep 12, 2024 •

edited

Loading

pilotseyea350 commented Sep 12, 2024

frankkopp commented Sep 13, 2024

chore: cpp framework improvements and additions #8640

chore: cpp framework improvements and additions #8640

Conversation

frankkopp commented Apr 30, 2024 • edited Loading

Summary of Changes

Testing instructions

How to download the PR for QA

2hwk commented May 3, 2024

Popespice commented Aug 22, 2024

tylerclt commented Aug 22, 2024

Maximilian-Reuter Aug 23, 2024

Choose a reason for hiding this comment

frankkopp Aug 23, 2024

Choose a reason for hiding this comment

Maximilian-Reuter Aug 23, 2024

Choose a reason for hiding this comment

frankkopp Aug 23, 2024

Choose a reason for hiding this comment

Maximilian-Reuter Aug 24, 2024

Choose a reason for hiding this comment

frankkopp Aug 24, 2024

Choose a reason for hiding this comment

pilotseyea350 commented Aug 23, 2024

frankkopp commented Aug 27, 2024

pilotseyea350 commented Sep 9, 2024

pilotseyea350 commented Sep 10, 2024 • edited Loading

pilotseyea350 commented Sep 12, 2024

frankkopp commented Sep 12, 2024

tracernz commented Sep 12, 2024 • edited Loading

pilotseyea350 commented Sep 12, 2024

frankkopp commented Sep 13, 2024

frankkopp commented Apr 30, 2024 •

edited

Loading

pilotseyea350 commented Sep 10, 2024 •

edited

Loading

tracernz commented Sep 12, 2024 •

edited

Loading