-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(a380x/air cond): wasm crash during rapid decompression #9543
Conversation
fbw-a380x/src/wasm/systems/a380_systems/src/air_conditioning/cpiom_b.rs
Outdated
Show resolved
Hide resolved
Quality Assurance Tester Discord Username : alexdnzdmb Testing Process: Fly for a few minutes, validate the wasm doesn't crash (the PFD continues to operate) and the cabin vertical speed stays within a reasonable range (+/- 100fpm) - check Testing Results: Negatives: Conclusions: Media: |
Thanks for the test @alexr4339 !! Sorry I forgot to mention that the indications only go to +/- 6400fpm (on the vertical speed) and 30,000ft (on the cabin altitude). This is a feature, not a bug 😄as that's how the ARINC data gets transmitted. You can see the real value of the cabin altitude checking the Although if you experienced no unexpected jumps in VS or in cabin temperature, and most importantly no wasm crashes, I don't think this needs to be tested again. |
can we merge this? |
All good from my side, will merge. |
…sim#9543) * fix: wasm crash during decompression * docs: changelog * fix: comments in update_ambient_conditions in cpiom_b
Fixes #9215
Summary of Changes
Fixes an issue with the cabin air flow demand calculation that was causing a wasm crash during rapid decompression.
Screenshots (if necessary)
References
Additional context
The main issue was with the way the pack demand flow and the cabin fan extraction flow was calculated (some values went negative, which drove other values to infinity). I've also added a couple of small fixes that should help in case of adirs failures in flight.
Discord username (if different from GitHub): Commander Ga
Testing instructions
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.