-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(a380x/fcu): Fix visual issues with FCU light test and missing labels #9570
base: master
Are you sure you want to change the base?
Conversation
* changed width of decimal point in FCU which didn't match the real aircraft * updated font also fixes issue of overlapping text during light test
…n FCU * Add TRUE label to FCU * Move FPA label to the correct position (left of V/S) * Move degree symbol closer to numbers based on reference photo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The true mode is already working FYI, so could be hooked up.
* add light test for pre-select baro setting * removed QFE label as QFE systems are not implemented and in the wrong position
FCU updates are complete for this PR. TRUE indication will be done in another PR due to some refactoring of the heading indication that will be done at the same time. |
.whenChanged() | ||
.handle((v) => this.lightsTest.set(v)); | ||
} | ||
|
||
render(): VNode | null { | ||
return ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend just using the same method as the navaid images for all of these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so using the map function? I'll give it a try again. I tried a few different methods and had trouble getting it to work but I think understand things a bit better now.
<img | ||
style="position: absolute; top: 0; left: 3740px" | ||
width="620px" | ||
class={{ hidden: this.lightsTest }} | ||
src={this.navaidMode2.map((v) => NdData.NAVAID_2_IMAGES[v])} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, like this. For the navaids specifically you can just add an extra state for light test, then you'll need a MappedSubject for each navaid mode, and a MappedSubject with two states (e.g. Normal and LightTest) that can be shared for all the others.
Fixes #9091
Summary of Changes
Screenshots (if necessary)
Old image
Updated Images
FPA Symbol
References
https://www.flickr.com/photos/75877584@N05/49491034416/in/photolist-2ipmuhQ-siX6c1-syfays-sAn7SW/
https://www.airliners.net/photo/Lufthansa/Airbus-A380-841/2736833/L?qsp=eJwtjEEKwjAQRa8is3ZRKYh0Vz2ALrzAMPloaDVhMqCh9O5Og7vH%2B5%2B3kKS34Wv3mkEDFbDKk/aUWflVaFhoQv0kDc409qdud0ky5Wj%2BKUntXN0HNowiyIbw91cN0G1CkZZ7eP7gAL01pv7oPsSSZ24NGMeZ1vUHSF4wZA%3D%3D
Additional context
Discord username (if different from GitHub): Heclak
Testing instructions
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.