Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(a380x/fcu): Fix visual issues with FCU light test and missing labels #9570

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

heclak
Copy link
Contributor

@heclak heclak commented Nov 21, 2024

Fixes #9091

Summary of Changes

  • Update display values on the FCU for the light test to match the reference image
  • Change decimal point width in FCU font to match font and display in reference. This fixes the overlapping text issue in the speed display. This replaces an older PR fix(a380/fcu): fixing speed overlap on light test #9129
  • Move the FPA label to the left of the V/S label as per reference
  • Add TRUE label. The label is not yet connected to TRUE mode but appears in the light test. Will be connected in a separate PR
  • Move the degree symbol closer to the speed value to match the reference
  • Changed first digit of FPA/VS to include different test digit (includes a +- symbol within the 8)
  • Change FPA to not use the left most +- character. FPA +- will be aligned under the "F" character
  • Add test pattern for EFIS CP labels

Screenshots (if necessary)

Old image
image
image

Updated Images
image
FlightSimulator_2024-11-23-10-41-55-260

FPA Symbol
image

References

https://www.flickr.com/photos/75877584@N05/49491034416/in/photolist-2ipmuhQ-siX6c1-syfays-sAn7SW/

image
https://www.airliners.net/photo/Lufthansa/Airbus-A380-841/2736833/L?qsp=eJwtjEEKwjAQRa8is3ZRKYh0Vz2ALrzAMPloaDVhMqCh9O5Og7vH%2B5%2B3kKS34Wv3mkEDFbDKk/aUWflVaFhoQv0kDc409qdud0ky5Wj%2BKUntXN0HNowiyIbw91cN0G1CkZZ7eP7gAL01pv7oPsSSZ24NGMeZ1vUHSF4wZA%3D%3D

image

Additional context

Discord username (if different from GitHub): Heclak

Testing instructions

  1. Set ANN LT sw to TEST. Check indication on FCU matches references and updated screenshots.
  2. Switch modes on the FCU to check that labels are displaying/hiding correctly outside of TEST mode. Change numbers on FCU.
  3. Check that preselect baro setting functions correctly. Preselect should timeout after a short time when in STD mode.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

* changed width of decimal point in FCU which didn't match the real aircraft

* updated font also fixes issue of overlapping text during light test
…n FCU

* Add TRUE label to FCU

* Move FPA label to the correct position (left of V/S)

* Move degree symbol closer to numbers based on reference photo
@heclak heclak marked this pull request as ready for review November 21, 2024 05:26
Copy link
Member

@tracernz tracernz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The true mode is already working FYI, so could be hooked up.

.github/CHANGELOG.md Outdated Show resolved Hide resolved
.github/CHANGELOG.md Outdated Show resolved Hide resolved
@2hwk 2hwk added the A380X Related to the A380X aircraft label Nov 21, 2024
@2hwk 2hwk added this to the v0.13.0 milestone Nov 21, 2024
@2hwk 2hwk added the QA Tier 1 label Nov 21, 2024
@heclak heclak marked this pull request as draft November 22, 2024 10:07
@heclak heclak marked this pull request as ready for review November 23, 2024 09:42
@heclak
Copy link
Contributor Author

heclak commented Nov 23, 2024

FCU updates are complete for this PR. TRUE indication will be done in another PR due to some refactoring of the heading indication that will be done at the same time.

@heclak heclak requested a review from 2hwk November 24, 2024 06:27
.whenChanged()
.handle((v) => this.lightsTest.set(v));
}

render(): VNode | null {
return (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend just using the same method as the navaid images for all of these.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so using the map function? I'll give it a try again. I tried a few different methods and had trouble getting it to work but I think understand things a bit better now.

<img
style="position: absolute; top: 0; left: 3740px"
width="620px"
class={{ hidden: this.lightsTest }}
src={this.navaidMode2.map((v) => NdData.NAVAID_2_IMAGES[v])}
Copy link
Member

@tracernz tracernz Nov 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, like this. For the navaids specifically you can just add an extra state for light test, then you'll need a MappedSubject for each navaid mode, and a MappedSubject with two states (e.g. Normal and LightTest) that can be shared for all the others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A380X Related to the A380X aircraft QA Tier 1
Projects
Status: 🟡 Code Review: Ready for Review
Development

Successfully merging this pull request may close these issues.

A380X/FCU: Light test speed window overlap
4 participants