Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a380x): Pressurization & AMU SimVar fixes #9579

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

flogross89
Copy link
Contributor

@flogross89 flogross89 commented Nov 23, 2024

Summary of Changes

Two fixes for SimVars, gets rid of error messages in MSFS2024. Won't have a huge functional impact I guess though.

Out of scope: L:A32NX_PRESS_OUTFLOW_VALVE_x_OPEN_PERCENTAGE_ANIM won't be populated, i.e. #9578 needs to be fixed with another PR

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@tracernz
Copy link
Member

tracernz commented Nov 23, 2024

Can you please split these into PRs that do one thing when you are ready to submit them? It's better for git blame, and also a lot better if one needs reverted (and also see https://github.com/flybywiresim/aircraft/blob/master/.github/Contributing.md).
If it's anything like the A32NX work I already did, you will find a lot of them are also bugs on FS2020, just less noticeable.

@tracernz tracernz added the MSFS2024 PRs Fixing FS2024 Issues label Nov 23, 2024
@flogross89
Copy link
Contributor Author

Can you please split these into PRs that do one thing when you are ready to submit them? It's better for git blame, and also a lot better if one needs reverted (and also see https://github.com/flybywiresim/aircraft/blob/master/.github/Contributing.md). If it's anything like the A32NX work I already did, you will find a lot of them are also bugs on FS2020, just less noticeable.

The fixes until now seem to be without QA, so I can do that

@flogross89 flogross89 changed the title fix(a380x): MSFS 2024 fixes, first batch fix(a380x): Pressurization & AMU SimVar fixes Nov 23, 2024
@flogross89 flogross89 marked this pull request as ready for review November 23, 2024 17:35
@flogross89 flogross89 added QA Not Required QA A380 Only QA only for A380 required A380X Related to the A380X aircraft and removed QA A380 Only QA only for A380 required labels Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A380X Related to the A380X aircraft MSFS2024 PRs Fixing FS2024 Issues QA Not Required
Projects
Status: 🟣 QA Review: Ready to Test
Development

Successfully merging this pull request may close these issues.

3 participants