Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a380x/mfd): Updated disabled input field styling #9749

Merged
merged 11 commits into from
Jan 30, 2025

Conversation

jet2code
Copy link
Contributor

Fixes #9734

Summary of Changes

  • Added $display-light-grey border to mfd-input-field-container.disabled:hover
  • Changed mfd-input-field-text-input.disabled text color to $display-dark-grey to match other disabled buttons and input fields.

This visually clarifies any confusion that pilots may have regarding the input field and its disabled state.

Screenshots (if necessary)

Before

image

After

image

References

Additional context

Discord username: john.xyz

Testing instructions

  • Ensure other input fields, disabled or not, are displayed correctly with no regressions.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@jet2code jet2code changed the title fix(A380X/MFD): Updated disabled input field styling fix(a380x/mfd): Updated disabled input field styling Jan 12, 2025
@G-DRAW
Copy link

G-DRAW commented Jan 12, 2025

Great job on the update.
I just want to clarify that the latest indication on these data entry fields are correct, but this layout appears after the first engine start.

There CPNY RTE and ALTN RTE fields with NONE in them should still display in blue after initialisation and before engine start.

I've also created another Issue for the missing amber boxes in the relevant entry fields, before the INIT A Page is filled out.

Copy link
Contributor

@flogross89 flogross89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this change makes sense. After you fixed the changelog, we can merge this PR.

@@ -3,7 +3,7 @@
<!-- ⚠⚠ Please follow the format provided ⚠⚠ -->
<!-- Always use "1." at the start instead of "2. " or "X. " as GitHub will auto renumber everything. -->
<!-- Use the following format below -->
<!-- 1. [Changed Area] Title of changes - @github username (Name) -->
1. [A380X/MFD] Updated disabled input field styling - @jet2code (john)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please put change at the end of all 0.13.0 changes

@flogross89
Copy link
Contributor

@G-DRAW The difference in CPNY/ALTN RTE stem from the fact that those two fields are still disabled in our FMS due to them not being implemented yet (also, since we don't really use CPNY RTEs in flight simming, there might not be a use for them). Once we enable them, they will also stay enabled after engine start, meaning they will show with cyan font.

@jet2code jet2code requested a review from flogross89 January 30, 2025 00:49
@flogross89 flogross89 merged commit 702d5eb into flybywiresim:master Jan 30, 2025
9 checks passed
@flogross89 flogross89 added FMS A380X Related to the A380X aircraft labels Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A380X Related to the A380X aircraft FMS
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

MFD: INIT A Page CPNY RTE and ALTN RTE display NONE in White
3 participants