-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(a380x/mfd): Updated disabled input field styling #9749
fix(a380x/mfd): Updated disabled input field styling #9749
Conversation
Great job on the update. There CPNY RTE and ALTN RTE fields with NONE in them should still display in blue after initialisation and before engine start. I've also created another Issue for the missing amber boxes in the relevant entry fields, before the INIT A Page is filled out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this change makes sense. After you fixed the changelog, we can merge this PR.
.github/CHANGELOG.md
Outdated
@@ -3,7 +3,7 @@ | |||
<!-- ⚠⚠ Please follow the format provided ⚠⚠ --> | |||
<!-- Always use "1." at the start instead of "2. " or "X. " as GitHub will auto renumber everything. --> | |||
<!-- Use the following format below --> | |||
<!-- 1. [Changed Area] Title of changes - @github username (Name) --> | |||
1. [A380X/MFD] Updated disabled input field styling - @jet2code (john) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please put change at the end of all 0.13.0 changes
@G-DRAW The difference in CPNY/ALTN RTE stem from the fact that those two fields are still disabled in our FMS due to them not being implemented yet (also, since we don't really use CPNY RTEs in flight simming, there might not be a use for them). Once we enable them, they will also stay enabled after engine start, meaning they will show with cyan font. |
fbw-a380x/src/systems/instruments/src/MFD/pages/common/style.scss
Outdated
Show resolved
Hide resolved
…sabled-input-field-css
…e/aircraft into disabled-input-field-css
Fixes #9734
Summary of Changes
$display-light-grey
border tomfd-input-field-container.disabled:hover
mfd-input-field-text-input.disabled
text color to$display-dark-grey
to match other disabled buttons and input fields.This visually clarifies any confusion that pilots may have regarding the input field and its disabled state.
Screenshots (if necessary)
Before
After
References
Additional context
Discord username: john.xyz
Testing instructions
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.