-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(comms): Comms panels in Rust #9755
Open
juliansebline
wants to merge
38
commits into
flybywiresim:master
Choose a base branch
from
juliansebline:comms-panels-rust
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(comms): Comms panels in Rust #9755
juliansebline
wants to merge
38
commits into
flybywiresim:master
from
juliansebline:comms-panels-rust
+3,546
−1,523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliansebline
changed the title
feat: Comms panels in Rust
feat(comms): Comms panels in Rust
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR makes all buttons on ACP and RMPs work and AudioSwitching knob too.
Plus, it adds an option in the EFB making the player able to choose on which side he/she is playing. By default, the option is set to "Auto" which means Captain.
You have to understand the concept:
Most of the logic been rewritten to Rust. This will be useful when failures come but more importantly, the code is meant to be portable to the A380.
Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub): julian_fbw
Testing instructions
COMM.txt
####### CAPTAIN SIDE: The controlling ACPs are either ACP1 or 3 (depending on AudioSwitching knob position) #######
To better spot the changes during the tests...
** PLEASE KEEP IN MIND ACP3 SHOULD HAVE NO EFFECT IF AUDIO SWITCHING KNOB ON NORM.**
** PLEASE KEEP IN MIND CAPTAIN'S ACP SHOULD HAVE NO EFFECT IF AUDIO SWITCHING KNOB ON CAPTAIN.**
####### F/O SIDE: The controlling ACPs are either ACP2 or 3 (depending on AudioSwitching knob position) #######
** PLEASE KEEP IN MIND ACP3 SHOULD HAVE NO EFFECT IF AUDIO SWITCHING KNOB ON NORM.**
** PLEASE KEEP IN MIND FO'S ACP SHOULD HAVE NO EFFECT IF AUDIO SWITCHING KNOB ON FO.**
####### ELECTRICITY CHECK #######
####### MORSE CHECK #######
For this you will have to open the behaviors window and local variables tab.
How to download the PR for QA
Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.