Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comms): Comms panels in Rust #9755

Open
wants to merge 38 commits into
base: master
Choose a base branch
from

Conversation

juliansebline
Copy link
Contributor

@juliansebline juliansebline commented Jan 14, 2025

Summary of Changes

This PR makes all buttons on ACP and RMPs work and AudioSwitching knob too.

Plus, it adds an option in the EFB making the player able to choose on which side he/she is playing. By default, the option is set to "Auto" which means Captain.

You have to understand the concept:

  1. "Captain" means any action on FO's ACP has no effect. If the AudioSwitching knob is rotated on Captain, ACP3 is preferred. If Rotated on F/O, no effect.
  2. "FO" means any action on Captain's ACP has no effect. If the AudioSwitching knob is rotated on F/O, ACP3 is preferred. If Rotated on Captain, no effect.

Most of the logic been rewritten to Rust. This will be useful when failures come but more importantly, the code is meant to be portable to the A380.

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub): julian_fbw

Testing instructions

COMM.txt

####### CAPTAIN SIDE: The controlling ACPs are either ACP1 or 3 (depending on AudioSwitching knob position) #######

To better spot the changes during the tests...

  • Set all knobs to 0 on CPT side
  • Set all knobs to 100 on FO side
  • Start the APU

** PLEASE KEEP IN MIND ACP3 SHOULD HAVE NO EFFECT IF AUDIO SWITCHING KNOB ON NORM.**

  • Understood

** PLEASE KEEP IN MIND CAPTAIN'S ACP SHOULD HAVE NO EFFECT IF AUDIO SWITCHING KNOB ON CAPTAIN.**

  • Understood
  1. Turn the knobs and push the buttons on Captain's ACP to different values than the other ACPs
  2. In the EFB, Sim Options page, select Left at the very bottom of the page
    • The simvars should now be set with Captain's ACP configuration
  3. Rotate VHF1 volume knob on Captain's ACP
    • The knob of this ACP only should be rotating
    • COM VOLUME:1 simvar should update accordingly
  4. Push VHF1 knob on Captain's ACP
    • The knob of this ACP only should be changing
  5. Push VHF1 transmit button on Captain's ACP
    • The button of this ACP only should be changing
    • Simvars PILOT TRANSMITTER TYPE = 0 if on, 4 if off
  6. Rotate VHF2 volume knob on Captain's ACP
    • The knob of this ACP only should be rotating
    • COM VOLUME:2 simvar should update accordingly
  7. Push VHF2 knob on Captain's ACP
    • The knob of this ACP only should be changing
  8. Push VHF2 transmit button on Captain's ACP
    • The button of this ACP only should be changing
    • Simvars PILOT TRANSMITTER TYPE = 1 if on, 4 if off
  9. Rotate HF1, HF2, Mech, Cab and PA knob on Captain's ACP
    • The knobs of this ACP only should be changing
  10. Push HF1, HF2, Mech, Cab and PA knob on Captain's ACP
    • The knobs of this ACP only should be changing
  11. Push HF1, HF2, Mech, Cab transmit buttons on Captain's ACP (except PA)
    • The buttons of this ACP only should be changing
    • Simvar PILOT TRANSMITTER TYPE == 4
  12. Keep pressing PA transmit button with left mouse button
    • PA push button should be on on Captain's ACP only
    • Release the mouse button, the light should return to the previous selected channel
    • Simvars PILOT TRANSMITTER TYPE == 4 if on, previous channel if off
  13. On each ACP, the INTRAD switch should be set to middle position
    • Yes
  14. Left click on it
    • The switch should go to the top position on Captain's ACP only
  15. Right click on it
    • The switch should remain in this position on Captain's ACP only
  16. Left click on it
    • The switch should return to middle position on Captain's ACP only
  17. Hold Right click on it
    • The switch should go to bottom position on Captain's ACP
  18. Release the right click
    • The switch should return to middle position on Captain's ACP
  19. Rotate the AudioSwitching knob to Captain
  20. Restart at point 3 of this part but replace Captain's ACP with ACP3
    • Passed
  21. Rotate the AudioSwitching knob to FO
    • The simvars should now be set with Captain's ACP configuration
  22. Rotate the AudioSwitching knob to NORM
    • Nothing should change

####### F/O SIDE: The controlling ACPs are either ACP2 or 3 (depending on AudioSwitching knob position) #######

** PLEASE KEEP IN MIND ACP3 SHOULD HAVE NO EFFECT IF AUDIO SWITCHING KNOB ON NORM.**

  • Understood

** PLEASE KEEP IN MIND FO'S ACP SHOULD HAVE NO EFFECT IF AUDIO SWITCHING KNOB ON FO.**

  • Understood
  1. Turn the knobs and push the buttons on FO's ACP to different values than the other ACPs
  2. In the EFB page, select Right, at the very bottom
    • The simvars should now be set with FO's ACP configuration
  3. Rotate VHF1 volume knob on FO's ACP
    • The knob of this ACP only should be rotating
    • COM VOLUME:1 simvar should update accordingly
  4. Push VHF1 knob on FO's ACP
    • The knob of this ACP only should be changing
    • COM RECEIVE EX1:1 should update accordingly
  5. Push VHF1 transmit button on FO's ACP
    • The button of this ACP only should be changing
    • Simvars PILOT TRANSMITTER TYPE = 0 if on, 4 if off
  6. Rotate VHF2 volume knob on FO's ACP
    • The knob of this ACP only should be rotating
    • COM VOLUME:2 simvar should update accordingly
  7. Push VHF2 knob on FO's ACP
    • The knob of this ACP only should be changing
    • COM RECEIVE EX1:2 should update accordingly
  8. Push VHF2 transmit button on FO's ACP
    • The button of this ACP only should be changing
    • Simvars PILOT TRANSMITTER TYPE = 1 if on, 4 if off
  9. Rotate HF1, HF2, Mech, Cab and PA knob on FO's ACP
    • The knobs of this ACP only should be changing
  10. Push HF1, HF2, Mech, Cab and PA knob on FO's ACP
    • The knobs of this ACP only should be changing
  11. Push HF1, HF2, Mech, Cab transmit buttons on FO's ACP (except PA)
    • The buttons of this ACP only should be changing
    • Simvars COPILOT TRANSMITTER TYPE == 4
  12. Keep pressing PA transmit button with left mouse button
    • PA push button should be on on FO's ACP only
    • Release the mouse button, the light should return to the previous selected channel
    • Simvars PILOT TRANSMITTER TYPE == 4 if on, previous channel if off
  13. On each ACP, the INTRAD switch should be set to middle position
    • Yes
  14. Left click on it
    • The switch should go to the top position on FO's ACP only
  15. Right click on it
    • The switch should remain in this position on FO's ACP only
  16. Left click on it
    • The switch should return to middle position on FO's ACP only
  17. Hold Right click on it
    • The switch should go to bottom position on FO's ACP
  18. Release the right click
    • The switch should return to middle position on FO's ACP
  19. Rotate the AudioSwitching knob to FO
  20. Restart at point 3 of this part but replace FO's ACP with ACP3
    • Passed
  21. Rotate the AudioSwitching knob to Captain
    • The simvars should now be set with FO's ACP configuration
  22. Rotate the AudioSwitching knob to NORM
    • Nothing should change
  23. In the EFB, select BOTH
    • ALL ACPs should be updated with FO's configuration as it was the last one used

####### ELECTRICITY CHECK #######

  1. Turn off the engines
    • Only the ACPs and RMP1 should be on
  2. Press the buttons and knobs
    • Only VHF1 simvars should be updated
  3. Turn off one battery and press many buttons on the ACPs
  4. Turn on the APU
    • The facade of each ACPs should not have changed

####### MORSE CHECK #######

For this you will have to open the behaviors window and local variables tab.

  1. For each VOR knob, press it, rotate it copy 883636401 in the VOR1/2_IDENT_PACKEDLvar
    • You should be hearing multiple beeps and squelch and squelch only if the lvar is empty
    • "BRIS" is the code. "-... .-. .. ... --.-" is what you should be hearing
  2. For each ADF knob, press it, rotate itn copy 883636401 in the ADF1/2_IDENT_PACKED Lvar
    • You should be hearing multiple beeps and squelch and squelch only if the lvar is empty
    • "BRIS" is the code. "-... .-. .. ... --.-" is what you should be hearing
  3. For the ILS knob, press it, rotate it copy 883636401 in the ILS_IDENT_PACKED Lvar and press the onside LS button on the FCU
    • You should be hearing multiple beeps and squelch and squelch only if the lvar is empty
    • "BRIS" is the code. "-... .-. .. ... --.-" is what you should be hearing
  4. Check also the sides are independant like in the previous steps.

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

@juliansebline juliansebline changed the title Comms panels rust feat: Comms panels rust Jan 14, 2025
@juliansebline juliansebline marked this pull request as ready for review January 14, 2025 16:34
@juliansebline juliansebline changed the title feat: Comms panels rust feat: Comms panels in Rust Jan 14, 2025
@juliansebline juliansebline changed the title feat: Comms panels in Rust feat(comms): Comms panels in Rust Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🟡 Code Review: Ready for Review
Development

Successfully merging this pull request may close these issues.

1 participant