Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix out of bounds map caches if too many tiles are loaded #81

Merged
merged 5 commits into from
Jul 16, 2023
Merged

fix out of bounds map caches if too many tiles are loaded #81

merged 5 commits into from
Jul 16, 2023

Conversation

svengcz
Copy link
Contributor

@svengcz svengcz commented May 1, 2023

Fixes issue report in A32NX repository:
flybywiresim/aircraft#7978

@svengcz svengcz mentioned this pull request May 1, 2023
Closed
@svengcz svengcz force-pushed the bugfix/arrayExceeding branch from f7f9db8 to d0431a6 Compare July 9, 2023 20:38
@svengcz svengcz marked this pull request as ready for review July 9, 2023 21:12
Saschl
Saschl approved these changes Jul 9, 2023
View reviewed changes
Copy link
Contributor

@Saschl Saschl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested yet, but looks good code wise.

@Saschl Saschl mentioned this pull request Jul 14, 2023
Open
@Saschl
Copy link
Contributor

Saschl commented Jul 16, 2023 •
edited
Loading

Tested in ENSB and NZFX and LOWI, terrain map was available and no crashes were seen.

image

@svengcz svengcz merged commit 1c5caac into main Jul 16, 2023
@svengcz svengcz deleted the bugfix/arrayExceeding branch July 16, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saschl Saschl Saschl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svengcz @Saschl