fix warning "Catch block may ignore exception"

flyingsaucerproject · May 26, 2024 · 2bda400 · 2bda400
1 parent 382de2e
commit 2bda400
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 4 deletions.
diff --git a/.idea/inspectionProfiles/Project_Default.xml b/.idea/inspectionProfiles/Project_Default.xml
diff --git a/flying-saucer-examples/src/main/java/BrowsePanel.java b/flying-saucer-examples/src/main/java/BrowsePanel.java
@@ -47,7 +47,7 @@
  */
 public class BrowsePanel {
     private static final Logger log = LoggerFactory.getLogger(BrowsePanel.class);
-    
+
     private String uri;
     private XHTMLPanel panel;
     private JFrame frame;
@@ -170,7 +170,7 @@ private void loadAndCheckArgs(String[] args) {
             try {
                 new URL(name);
             } catch (MalformedURLException e) {
-                throw new IllegalArgumentException("File " + name + " does not exist or is not a URI");
+                throw new IllegalArgumentException("File " + name + " does not exist or is not a URI", e);
             }
         }
         this.uri = name;

diff --git a/flying-saucer-swt-examples/src/main/java/org/xhtmlrenderer/demo/browser/swt/Browser.java b/flying-saucer-swt-examples/src/main/java/org/xhtmlrenderer/demo/browser/swt/Browser.java
@@ -283,12 +283,14 @@ private Image loadImage(@Nullable String icon) {
         try {
             url = new URL(uri);
         } catch (MalformedURLException e) {
+            log.debug("Failed to load image {} from uri {}", icon, uri, e);
             return null;
         }
         InputStream is;
         try {
             is = url.openStream();
         } catch (IOException e) {
+            log.debug("Failed to load image {} from uri {}", icon, uri, e);
             return null;
         }
         if (is == null) {

diff --git a/...aucer-swt-examples/src/main/java/org/xhtmlrenderer/demo/browser/swt/BrowserUserAgent.java b/...aucer-swt-examples/src/main/java/org/xhtmlrenderer/demo/browser/swt/BrowserUserAgent.java
@@ -96,7 +96,7 @@ public String resolveURI(@Nullable String uri) {
                         ref = new URL(duri);
                     }
                 } catch (MalformedURLException e) {
-                    Uu.p("URI/URL is malformed: " + burl + " or " + uri);
+                    Uu.p("URI/URL is malformed: %s or %s (caused by: %s)".formatted(burl, uri, e));
                 }
             } else {
                 if (!short_url.startsWith("/")) {
@@ -119,7 +119,7 @@ public String resolveURI(@Nullable String uri) {
                 }
                 ref = new URL(base, uri);
             } catch (MalformedURLException e) {
-                Uu.p("URI/URL is malformed: " + burl + " or " + uri);
+                Uu.p("URI/URL is malformed: %s or %s (caused by: %s)".formatted(burl, uri, e));
             }
         }