#340 don't re-assign local variable

flyingsaucerproject · Jul 19, 2024 · 600b3ea · 600b3ea
1 parent 20e3f87
commit 600b3ea
Showing 1 changed file with 4 additions and 10 deletions.
diff --git a/flying-saucer-core/src/main/java/org/xhtmlrenderer/simple/xhtml/controls/SelectControl.java b/flying-saucer-core/src/main/java/org/xhtmlrenderer/simple/xhtml/controls/SelectControl.java
@@ -72,17 +72,11 @@ private void traverseOptions(Element e, String prefix) {
                     traverseOptions(child, prefix + child.getAttribute("label")
                             + " ");
                 } else if (child.getNodeName().equalsIgnoreCase("option")) {
-                    String value = child.getAttribute("value");
-                    String label = child.getAttribute("label");
+                    String valueAttribute = child.getAttribute("value");
+                    String labelAttribute = child.getAttribute("label");
                     String content = collectText(child);
-                    if (value.isEmpty()) {
-                        value = content;
-                    }
-                    if (label.isEmpty()) {
-                        label = content;
-                    } else {
-                        label = prefix + label;
-                    }
+                    String value = valueAttribute.isEmpty() ? content : valueAttribute;
+                    String label = labelAttribute.isEmpty() ? content : prefix + labelAttribute;
                     _options.put(value, label);
                     if (!child.getAttribute("selected").isEmpty()) {
                         if (isMultiple()) {