#340 fix warning "Iteration over 'keySet()' can be optimized"

flyingsaucerproject · Jul 19, 2024 · ab672a4 · ab672a4
1 parent 17d27d5
commit ab672a4
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/flying-saucer-core/src/main/java/org/xhtmlrenderer/test/ReferenceComparison.java b/flying-saucer-core/src/main/java/org/xhtmlrenderer/test/ReferenceComparison.java
@@ -270,12 +270,12 @@ private void checking(File source) {
 
         private void report() {
             int failed = 0;
-            for (File file : files.keySet()) {
-                Result result = files.get(file);
+            for (Map.Entry<File, Result> entry : files.entrySet()) {
+                Result result = entry.getValue();
 
                 if (result instanceof FailedResult) {
                     failed++;
-                    System.out.println(result.describe(file));
+                    System.out.println(result.describe(entry.getKey()));
                 }
             }
             System.out.println("Checked " + files.keySet().size() + " files, " + (failed > 0 ? failed + " failed." : "all OK."));
@@ -332,4 +332,4 @@ public String describe(File file) {
         }
     }
 
-}
+}
diff --git a/flying-saucer-pdf/src/main/java/org/xhtmlrenderer/pdf/util/XHtmlMetaToPdfInfoAdapter.java b/flying-saucer-pdf/src/main/java/org/xhtmlrenderer/pdf/util/XHtmlMetaToPdfInfoAdapter.java
@@ -222,8 +222,9 @@ private void parseHtmlMetaTags( Document doc ) {
      */
     private void addPdfMetaValuesToPdfDocument( ITextRenderer renderer ) {
 
-        for (PdfName pdfName : this.pdfInfoValues.keySet()) {
-            PdfString pdfString = pdfInfoValues.get(pdfName);
+        for (Map.Entry<PdfName, PdfString> entry : pdfInfoValues.entrySet()) {
+            PdfName pdfName = entry.getKey();
+            PdfString pdfString = entry.getValue();
             XRLog.render(Level.FINEST, "pdfName=" + pdfName + ", pdfString=" + pdfString);
             renderer.getOutputDevice().getWriter().getInfo().put(pdfName, pdfString);
         }