Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

org.xmlrenderer:flying-saucer-pdf does not work with Java 9 modules #349

Closed
VerachtertAaron opened this issue Jul 17, 2024 · 4 comments · Fixed by #351
Closed

org.xmlrenderer:flying-saucer-pdf does not work with Java 9 modules #349

VerachtertAaron opened this issue Jul 17, 2024 · 4 comments · Fixed by #351
Milestone

Comments

@VerachtertAaron
Copy link

As mentioned in https://groups.google.com/g/flying-saucer-users/c/kw3FnbSIS2E, there is a package naming conflict between org.xmlrenderer:flying-saucer-pdf and org.xmlrenderer:flying-saucer-core: package org.xhtmlrenderer.simple is present in both jars.

This causes projects using Java 9 modules to not be able to load both dependencies correctly. The fix proposed in the google groups thread would solve this.

@VerachtertAaron
Copy link
Author

Pull request made.

@asolntsev asolntsev added this to the 9.9.0 milestone Jul 19, 2024
asolntsev pushed a commit that referenced this issue Jul 19, 2024
@asolntsev
Copy link
Contributor

asolntsev commented Jul 19, 2024

@VerachtertAaron @andreasrosdal I also see package "org.xhtmlrenderer.simple" is still used in two different modules: "core" and "swt".

Shouldn't we rename the package in "swt" module as well?
See PR #351

image

asolntsev added a commit that referenced this issue Jul 19, 2024
…cer-swt"

to avoid the collision when the same package is found in two modules ("flaying-saucer-core" and "flaying-saucer-swt").
Java 9 modules doesn't allow such a collision.
asolntsev added a commit that referenced this issue Jul 19, 2024
…cer-swt"

to avoid the collision when the same package is found in two modules ("flaying-saucer-core" and "flaying-saucer-swt").
Java 9 modules doesn't allow such a collision.
@asolntsev
Copy link
Contributor

Fixed by #350 and #351

@asolntsev
Copy link
Contributor

@VerachtertAaron Hi. Can you confirm that the problem was fixed in FS 9.9.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants