Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Make OAuth Scopes configurable #657

Closed
2 of 4 tasks
EngHabu opened this issue Jan 5, 2021 · 0 comments
Closed
2 of 4 tasks

[Feature] Make OAuth Scopes configurable #657

EngHabu opened this issue Jan 5, 2021 · 0 comments
Labels
enhancement New feature or request security Issues related to Security improvements
Milestone
0.11.0

Comments

@EngHabu
Copy link
Contributor

EngHabu commented Jan 5, 2021 •
edited
Loading

Motivation: Why do you think this is important?
Flyteadmin hardcodes the list of OAuth scopes it requests to profile, openid (common) and offline_access (only supported in some IdPs)

Flyte component

  • FlyteAdmin (Control Plane service)

Success Criteria

  • FlyteAdmin changes to make sure it works with Google OIdC, Okta and Github,
  • Flyte docs updates to show examples of how to do that for these providers,
  • FlyteKit changes if any to support the new flow.
@EngHabu EngHabu added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels Jan 5, 2021
@EngHabu EngHabu mentioned this issue Jan 5, 2021
Merged
8 tasks
@EngHabu EngHabu added this to the 0.11.0 milestone Jan 11, 2021
@kumare3 kumare3 added security Issues related to Security improvements and removed untriaged This issues has not yet been looked at by the Maintainers labels Feb 9, 2021
@EngHabu EngHabu mentioned this issue Feb 23, 2021
Closed
EngHabu added a commit to flyteorg/flyteconsole that referenced this issue Feb 23, 2021
@EngHabu
Use name if preferredUsername is empty
dc5eaaa 
flyteorg/flyte#657
@EngHabu EngHabu mentioned this issue Feb 23, 2021
Merged
8 tasks
EngHabu added a commit to flyteorg/flyteconsole that referenced this issue Feb 24, 2021
@EngHabu
fix: Use name if preferredUsername is empty (#148)
0cdd983 
* Use name if preferredUsername is empty

flyteorg/flyte#657

* check for empty string
@EngHabu EngHabu closed this as completed Mar 3, 2021
@EngHabu EngHabu mentioned this issue May 1, 2021
Merged
pvditt added a commit that referenced this issue Feb 19, 2025
@pvditt
set terminated primary container w/ sigkill exit code to be a system …
d79ce30 
…failure (#657)

* set terminated primary container to be a system failure

Signed-off-by: Paul Dittamo <pvdittamo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request security Issues related to Security improvements
Projects
None yet
Milestone
0.11.0
Development

No branches or pull requests
2 participants
@EngHabu @kumare3