Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Union type with dataclass ambiguous error and support superset comparison #5858

Merged
merged 30 commits into from
Nov 20, 2024

refactor: make go-tidy

0def0ad
Select commit
Loading
Failed to load commit list.
Merged

Fix Union type with dataclass ambiguous error and support superset comparison #5858

refactor: make go-tidy
0def0ad
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 18, 2024 in 0s

35.34% (-1.81%) compared to d2ddfe2

View this Pull Request on Codecov

35.34% (-1.81%) compared to d2ddfe2

Details

Codecov Report

Attention: Patch coverage is 60.41667% with 19 lines in your changes missing coverage. Please review.

Project coverage is 35.34%. Comparing base (d2ddfe2) to head (0def0ad).

Files with missing lines Patch % Lines
flytepropeller/pkg/compiler/validators/typing.go 60.41% 17 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5858      +/-   ##
==========================================
- Coverage   37.14%   35.34%   -1.81%     
==========================================
  Files        1313     1147     -166     
  Lines      131619   122881    -8738     
==========================================
- Hits        48891    43432    -5459     
+ Misses      78481    75693    -2788     
+ Partials     4247     3756     -491     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.