fix: this is rfc, do not deploy until resolved; details in comments

Signed-off-by: Jason Porter <jason@union.ai>
flyteorg · Jun 7, 2021 · 8955aab · 8955aab
1 parent d27e70d
commit 8955aab
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/components/Executions/utils.ts b/src/components/Executions/utils.ts
@@ -113,7 +113,12 @@ export const taskExecutionIsTerminal = (taskExecution: TaskExecution) =>
     terminalTaskExecutionStates.includes(taskExecution.closure.phase);
 
 export function getNodeExecutionSpecId(nodeExecution: NodeExecution): string {
-    return nodeExecution.metadata?.specNodeId || nodeExecution.id.nodeId;
+    /** RFC: DO NOT DEPLOY UNTIL RESOLVED
+     * I am unclear on the implications of removing ternary here
+     *
+     * modified: return nodeExecution.metadata?.specNodeId || nodeExecution.id.nodeId;
+     */
+    return nodeExecution.id.nodeId;
 }
 
 interface GetExecutionDurationMSArgs {