Skip to content

Commit

Permalink
fix: service account is not properly propagated from execution info v2
Browse files Browse the repository at this point in the history
Signed-off-by: eugenejahn <eugenejahnjahn@gmail.com>
  • Loading branch information
eugenejahn committed Apr 13, 2022
1 parent 3542030 commit 9d1e7d6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ export const ExecutionMetadataExtra: React.FC<{
launchPlan: launchPlanId,
maxParallelism,
rawOutputDataConfig,
authRole,
securityContext,
} = execution.spec;

Expand All @@ -51,14 +50,12 @@ export const ExecutionMetadataExtra: React.FC<{
const details: DetailItem[] = [
{
label: ExecutionMetadataLabels.iam,
value: authRole?.assumableIamRole || ExecutionMetadataLabels.securityContextDefault,
value: securityContext?.runAs?.iamRole || ExecutionMetadataLabels.securityContextDefault,
},
{
label: ExecutionMetadataLabels.serviceAccount,
value:
authRole?.kubernetesServiceAccount ||
securityContext?.runAs?.k8sServiceAccount ||
ExecutionMetadataLabels.securityContextDefault,
securityContext?.runAs?.k8sServiceAccount || ExecutionMetadataLabels.securityContextDefault,
},
{
label: ExecutionMetadataLabels.rawOutputPrefix,
Expand Down
4 changes: 0 additions & 4 deletions src/models/Execution/api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -122,10 +122,6 @@ export const createWorkflowExecution = (
annotations,
};

if (authRole?.assumableIamRole || authRole?.kubernetesServiceAccount) {
spec.authRole = authRole;
}

if (securityContext?.runAs?.iamRole || securityContext?.runAs?.k8sServiceAccount) {
spec.securityContext = securityContext;
}
Expand Down

0 comments on commit 9d1e7d6

Please sign in to comment.