fix: handle null LiteralMap in RemoteLiteralMapViewer

flyteidl generated JS code uses null as a default value for non-primitive objects.
flyteorg · Nov 9, 2020 · cc8e66a · cc8e66a
1 parent 6685288
commit cc8e66a
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/src/components/Literals/RemoteLiteralMapViewer.tsx b/src/components/Literals/RemoteLiteralMapViewer.tsx
@@ -28,7 +28,7 @@ const BlobTooLarge: React.FC<{ url: string }> = ({ url }) => (
  */
 export const RemoteLiteralMapViewer: React.FC<{
     blob: UrlBlob;
-    map?: LiteralMap;
+    map: LiteralMap | null;
 }> = ({ blob, map }) => {
     if (!blob.url || !blob.bytes) {
         return (
@@ -38,7 +38,7 @@ export const RemoteLiteralMapViewer: React.FC<{
         );
     }
 
-    if (map !== undefined) {
+    if (map != null) {
         return <LiteralMapViewer map={map} />;
     }
 

diff --git a/src/components/Literals/test/RemoteLiteralMapViewer.test.tsx b/src/components/Literals/test/RemoteLiteralMapViewer.test.tsx
@@ -18,7 +18,7 @@ describe('RemoteLiteralMapViewer', () => {
         };
 
         const { getAllByText } = render(
-            <RemoteLiteralMapViewer map={undefined} blob={blob} />
+            <RemoteLiteralMapViewer map={null} blob={blob} />
         );
 
         const items = getAllByText('No data is available.');
@@ -45,7 +45,7 @@ describe('RemoteLiteralMapViewer', () => {
         expect(items.length).toBe(1);
     });
 
-    it('fetches blob if map is undefined', () => {
+    it('fetches blob if map is null', () => {
         const map: LiteralMap = {
             literals: {
                 input1: {}
@@ -65,7 +65,7 @@ describe('RemoteLiteralMapViewer', () => {
         };
 
         const { getAllByText } = render(
-            <RemoteLiteralMapViewer map={undefined} blob={blob} />
+            <RemoteLiteralMapViewer map={null} blob={blob} />
         );
 
         const items = getAllByText('input1:');

diff --git a/src/models/Execution/types.ts b/src/models/Execution/types.ts
@@ -132,6 +132,6 @@ export interface TaskExecutionClosure extends Admin.ITaskExecutionClosure {
 export interface ExecutionData {
     inputs: UrlBlob;
     outputs: UrlBlob;
-    fullInputs?: LiteralMap;
-    fullOutputs?: LiteralMap;
+    fullInputs: LiteralMap | null;
+    fullOutputs: LiteralMap | null;
 }