Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved ServePlugin to both env #238

Closed
wants to merge 1 commit into from
Closed

Conversation

jsonporter
Copy link
Contributor

This commit moves the webpack-plugin-serve middleware to apply to both prod and dev builds

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Serve middleware sets the MIME type of main-[hash].js to `application/javascrtipt'. This middleware was initially configured to apply to dev-only; this change applies it to both prod and dev builds.

Tracking Issue

Follow-up issue

#235

Signed-off-by: Jason Porter <jason@union.ai>
@jsonporter jsonporter force-pushed the fix/add-mime-type-to-prod branch from 48f7da5 to b2fa26e Compare November 17, 2021 03:30
@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@5e83da6). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #238   +/-   ##
=========================================
  Coverage          ?   63.44%           
=========================================
  Files             ?      365           
  Lines             ?     7909           
  Branches          ?     1385           
=========================================
  Hits              ?     5018           
  Misses            ?     2891           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e83da6...b2fa26e. Read the comment docs.

@jsonporter jsonporter closed this Nov 17, 2021
@anrusina anrusina deleted the fix/add-mime-type-to-prod branch January 26, 2022 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant