This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Lazily initialize kubernetes client only when using kube api watcher #56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Lazily load k8s client only in kubeapi watcher. This prevents init container errors when running with service accounts that have
automountServiceAccountToken: false
set. Smoke tested in sandbox with and withoutautomountServiceAccountToken: false
, with both the default shared process namespace watcher and kubeapi watcher respectively.Type
Are all requirements met?
Complete description
Moved initialization of k8s client from copilot root command to
NewKubeAPIWatcher
function. Now it is only initialized when thekube-api
watcher is specified.