Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add motherduck support for duckdb plugin #2680
add motherduck support for duckdb plugin #2680
Changes from 10 commits
6876d44
c4911ce
8bcad3f
14e8c00
d0de008
6d5f81e
7e47ab0
ff85ef9
7fa17af
f581071
a985f35
3cce81e
7fb7783
e000e33
daba654
019aa86
d2d4098
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using an enum restricts someone from passing a callable. Lets say someone wants to add a new keyword to
duckdb.connect
for motherduck:They should be a to pass it into provider:
If you prefer an enum, I think we also open it up to callables:
In the above callable API, I propose making the input just be a string. To pass in the secret the user API becomes:
then in `DuckDBQuery._connect_to_duckdb:
This way the callable does not need to be responsible for handling
current_context
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do!! Thank you.
I will also use
secret_requests
fromPythonAutoContainerTask
and check for it in the constructor rather than adding a new secret argument.