Skip to content
This repository has been archived by the owner on Jul 16, 2020. It is now read-only.

Set uriOrEmpty from oneOf to anyOf for compatibility with validators that do not implement format uri #16

Merged
merged 2 commits into from
Aug 30, 2017

Conversation

kofalt
Copy link
Member

@kofalt kofalt commented Aug 30, 2017

From the spec:

JSON Schema implementations are not required to implement this part of the specification, and many of them do not.

If a validator does not implement "format": "uri", validation will fail because oneOf will be matched by both clauses. This changes it for anyOf, which will have no effect on complete parsers and be compatible with incomplete ones.


Is this a semantic or operational change? If so:

  • Increment the version in spec/readme.md
  • After merge, tag the version and update the release page

@kofalt kofalt requested review from gsfr and nagem August 30, 2017 21:52
@kofalt
Copy link
Member Author

kofalt commented Aug 30, 2017

Very trivial change so merging to move this forward.

@kofalt kofalt merged commit 893ff41 into master Aug 30, 2017
@kofalt kofalt deleted the uriOrEmpty-compat branch August 30, 2017 22:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants