Skip to content
This repository has been archived by the owner on Jul 16, 2020. It is now read-only.

Document the current bash requirement #24

Merged
merged 1 commit into from
Dec 1, 2017
Merged

Document the current bash requirement #24

merged 1 commit into from
Dec 1, 2017

Conversation

ehlertjd
Copy link
Contributor

@ehlertjd ehlertjd commented Nov 30, 2017

Added an explicit clarification of the minimum container requirements for the current version of the spec. Ultimately we'd like to look into removing the bash requirement in a future version.


Is this a semantic or operational change? NO If so:

  • Increment the version in spec/readme.md
  • After merge, tag the version and update the release page

Refs #21
@kofalt @gsfr

@gsfr gsfr self-requested a review November 30, 2017 22:42
Copy link

@gsfr gsfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as long as this doesn't close #21.

@kofalt
Copy link
Member

kofalt commented Dec 1, 2017

It won't - when a ticket would be closed, Github now adds a dotted line under the text responsible & a tooltip explaining what will happen. It's slick :)

Copy link
Member

@kofalt kofalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me as well.

@kofalt
Copy link
Member

kofalt commented Dec 1, 2017

Question @ehlertjd - was there a pull request comment template? There's supposed to be one.

I dislike the things personally, but it's nice for this one to remind us when to bump the spec version.

@ehlertjd
Copy link
Contributor Author

ehlertjd commented Dec 1, 2017

@kofalt Yeah, just dropped it back into the original comment

@ehlertjd ehlertjd merged commit 889ff61 into master Dec 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants