Skip to content
This repository has been archived by the owner on Jul 16, 2020. It is now read-only.

Read-only API keys, stricter schema typing, and more examples #35

Merged
merged 3 commits into from
Aug 27, 2018

Conversation

kofalt
Copy link
Member

@kofalt kofalt commented Aug 27, 2018

Until now, the schema combined all gear input types. This allowed schema directives to be added to input types that would be ignored (context, api-key).

This PR fixes that while also adding a read-only specifier to the api-key type, provides some more bona-fide validation tests, and adds missing documentation about the api-key input. Notably absent are invalid examples, which we should add at some point.


Is this a semantic or operational change? If so:

  • Increment the version in spec/readme.md
  • After merge, tag the version and update the release page

Copy link
Contributor

@ehlertjd ehlertjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It is possible to interact with the Flywheel data hierarchy using our [python](https://flywheel-io.github.io/core/branches/master/python/getting_started.html), [matlab](https://flywheel-io.github.io/core/branches/master/matlab/getting_started.html), and (slated for an overhaul) [golang](https://github.com/flywheel-io/sdk) SDKs.

Generally, you will want to figure out a script that you like, using your normal user API key, before turning it into a gear. To do this, specify an `api-key` type input as show in the example above, and use that value in your gear script.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe one-sentence call-out that by default the api-key will have write permissions and can be made read-only.

Copy link
Member Author

@kofalt kofalt Aug 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's in the example blob, but I'll add it here too. Good to have in both places

@kofalt kofalt merged commit 85cddf7 into master Aug 27, 2018
@kofalt kofalt deleted the api-key-ro branch August 27, 2018 21:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

5 participants