Skip to content

Commit

Permalink
Rollup merge of rust-lang#125369 - saethlin:synthetic-targets-dont-cc…
Browse files Browse the repository at this point in the history
…, r=onur-ozkan

Don't do cc detection for synthetic targets

Fixes rust-lang#125365

Synthetic targets only exist for mir-opt tests, and the mir-opt tests suite is in general designed to avoid any use of a C compiler. We don't need to do CC detection. It's unclear to me how this code didn't cause issues before.
  • Loading branch information
fmease authored May 21, 2024
2 parents 855b679 + 51cf381 commit 2202601
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions src/bootstrap/src/core/build_steps/synthetic_targets.rs
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,5 @@ fn create_synthetic_target(
customize(spec_map);

std::fs::write(&path, serde_json::to_vec_pretty(&spec).unwrap()).unwrap();
let target = TargetSelection::create_synthetic(&name, path.to_str().unwrap());
crate::utils::cc_detect::find_target(builder, target);

target
TargetSelection::create_synthetic(&name, path.to_str().unwrap())
}

0 comments on commit 2202601

Please sign in to comment.