[wip] generic consts #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmease
force-pushed
the
generic-consts
branch
2 times, most recently
from
0c39c9b
to
554c26c
Compare
Repository owner
locked and limited conversation to collaborators
Jun 27, 2023
fmease
commented
Jul 2, 2023
fmease
commented
Jul 2, 2023
fmease
commented
Jul 2, 2023
fmease
force-pushed
the
generic-consts
branch
4 times, most recently
from
bc7403d
to
10de81b
Compare
fmease
commented
Jul 3, 2023
| @@ -50,7 +50,11 @@ impl<'tcx> LateLintPass<'tcx> for LargeConstArrays { | |||
| fn check_item(&mut self, cx: &LateContext<'tcx>, item: &'tcx Item<'_>) { | |||
| if_chain! { | |||
| if !item.span.from_expansion(); | |||
| if let ItemKind::Const(hir_ty, _) = &item.kind; | |||
| if let ItemKind::Const(hir_ty, generics, _) = &item.kind; | |||
| // Since static items may not have generics, skip generic consts. | |||
fmease
commented
Jul 5, 2023
compiler/rustc_resolve/src/late.rs
Outdated
| @@ -4420,7 +4491,9 @@ struct LifetimeCountVisitor<'a, 'b, 'tcx> { | |||
| impl<'ast> Visitor<'ast> for LifetimeCountVisitor<'_, '_, '_> { | |||
| fn visit_item(&mut self, item: &'ast Item) { | |||
| match &item.kind { | |||
| // @Question (minor, style) order | |||
There was a problem hiding this comment.
Suggested change
| // @Question (minor, style) order |
yo, that should've been gone already by now!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.