Remove obsolete msvc workarounds (#3388)

This bug in the modules implementation is fixed since at least msvc 19.34, possibly even earlier like 19.32.
fmtlib · Apr 20, 2023 · 18e7a25 · 18e7a25
1 parent 0489c19
commit 18e7a25
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 15 deletions.
diff --git a/include/fmt/core.h b/include/fmt/core.h
@@ -2496,9 +2496,6 @@ FMT_CONSTEXPR auto parse_replacement_field(const Char* begin, const Char* end,
 template <bool IS_CONSTEXPR, typename Char, typename Handler>
 FMT_CONSTEXPR FMT_INLINE void parse_format_string(
     basic_string_view<Char> format_str, Handler&& handler) {
-  // Workaround a name-lookup bug in MSVC's modules implementation.
-  using detail::find;
-
   auto begin = format_str.data();
   auto end = begin + format_str.size();
   if (end - begin < 32) {

diff --git a/include/fmt/format.h b/include/fmt/format.h
@@ -4492,18 +4492,6 @@ FMT_BEGIN_DETAIL_NAMESPACE
 template <typename Char>
 void vformat_to(buffer<Char>& buf, basic_string_view<Char> fmt,
                 typename vformat_args<Char>::type args, locale_ref loc) {
-  // workaround for msvc bug regarding name-lookup in module
-  // link names into function scope
-  using detail::arg_formatter;
-  using detail::buffer_appender;
-  using detail::custom_formatter;
-  using detail::default_arg_formatter;
-  using detail::get_arg;
-  using detail::locale_ref;
-  using detail::parse_format_specs;
-  using detail::to_unsigned;
-  using detail::type;
-  using detail::write;
   auto out = buffer_appender<Char>(buf);
   if (fmt.size() == 2 && equal2(fmt.data(), "{}")) {
     auto arg = args.get(0);