Skip to content

Commit

Permalink
Fixed all clang -Wsigned-enum-bitfield warnings
Browse files Browse the repository at this point in the history
Made enums involved in bitfields unsigned.

Due to a bug, gcc < 9.3 warns about bitfields not being big enough to hold the enum, even though they are. So keep the plain enum for old gcc.
  • Loading branch information
seanm committed May 5, 2022
1 parent 7e4ad40 commit c92da16
Showing 1 changed file with 9 additions and 3 deletions.
12 changes: 9 additions & 3 deletions include/fmt/core.h
Original file line number Diff line number Diff line change
Expand Up @@ -2029,14 +2029,20 @@ template <typename Context> class basic_format_args {
// between clang and gcc on ARM (#1919).
using format_args = basic_format_args<format_context>;

// We cannot use enum classes as bit fields because of a gcc bug
// We cannot use enum classes as bit fields because of a gcc bug before 9.3
// https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61414.
#if FMT_GCC_VERSION && FMT_GCC_VERSION < 903
# define FMT_ENUM_UNDERLYING_TYPE(type)
#else
# define FMT_ENUM_UNDERLYING_TYPE(type) : type
#endif

namespace align {
enum type { none, left, right, center, numeric };
enum type FMT_ENUM_UNDERLYING_TYPE(unsigned char) { none, left, right, center, numeric };
}
using align_t = align::type;
namespace sign {
enum type { none, minus, plus, space };
enum type FMT_ENUM_UNDERLYING_TYPE(unsigned char) { none, minus, plus, space };
}
using sign_t = sign::type;

Expand Down

0 comments on commit c92da16

Please sign in to comment.