Suppress -Wfloat-equal

fmtlib · Apr 1, 2022 · ef54f9a · ef54f9a
1 parent 288c3b9
commit ef54f9a
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/include/fmt/format.h b/include/fmt/format.h
@@ -2293,21 +2293,21 @@ FMT_CONSTEXPR20 auto write_float(OutputIt out, const DecimalFP& fp,
   }
 }
 
+template <typename T> constexpr bool isnan(T value) {
+  return !(value >= value);  // std::isnan doesn't support __float128.
+}
+
 template <typename T, FMT_ENABLE_IF(std::is_floating_point<T>::value &&
                                     !is_float128<T>::value)>
 FMT_CONSTEXPR20 bool isfinite(T value) {
-  if (is_constant_evaluated()) return value - value == 0;
+  if (is_constant_evaluated()) return !isnan(value - value);
   return std::isfinite(value);
 }
 template <typename T, FMT_ENABLE_IF(is_float128<T>::value)>
 constexpr bool isfinite(T value) {
   return value - value == 0;  // std::isfinite doesn't support __float128.
 }
 
-template <typename T> constexpr bool isnan(T value) {
-  return value != value;  // std::isnan doesn't support __float128.
-}
-
 template <typename T, FMT_ENABLE_IF(is_floating_point<T>::value)>
 FMT_INLINE FMT_CONSTEXPR bool signbit(T value) {
   if (is_constant_evaluated()) {