-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warnings with g++ 8.2.0 #1105
Comments
Correction, there are four coming from ostream.h. The final one is on line 105. |
Thanks for reporting this. Shadowing warnings are very noisy and in general have zero value which is why they are disabled by default (even with Also this diagnostics looks like a bug in gcc, please report there:
|
If the shadow warnings are supposed to be explicitly disabled, then that feature does not appear to be working. When I #include fmt headers in my own build, I get more than 600 shadow warnings originating in fmt. |
Sorry, I must have misunderstood the issue. Looking at the logs I saw you are building {fmt} itself with shadowing warnings enabled. |
I sent a log from building fmt directly because my code is not publicly available. I use fmt as header-only within my code. The shadow warnings I'm seeing in my code all originate from fmt's ostream.h. |
Yes, thank you! |
Compiling using g++ 8.2.0 with -Wall -Wshadow -pedantic results in -Wshadow and -Wdangling-else warnings. For me personally, the most critical to be remedied are the three distinct -Wshadow warnings coming from include/fmt/ostream.h (lines 25, 75, and 89) on the master branch.
build.log
The text was updated successfully, but these errors were encountered: