error: expected (primary-)expression when building on FreeBSD 12

[vedranmiletic]

With Clang 6:

Building CXX object test/CMakeFiles/assert-test.dir/assert-test.cc.o
FAILED: test/CMakeFiles/assert-test.dir/assert-test.cc.o 
/usr/bin/c++  -DFMT_USE_FILE_DESCRIPTORS=1 -DGTEST_HAS_STD_WSTRING=1 -DGTEST_USE_OWN_TR1_TUPLE=1 -D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING=1 -Iinclude -isystem test/gtest -isystem test/gmock -isystem test/. -O3 -DNDEBUG   -std=gnu++11 -MD -MT test/CMakeFiles/assert-test.dir/assert-test.cc.o -MF test/CMakeFiles/assert-test.dir/assert-test.cc.o.d -o test/CMakeFiles/assert-test.dir/assert-test.cc.o -c test/assert-test.cc
test/assert-test.cc:20:3: error: expected expression
  EXPECT_DEBUG_DEATH_IF_SUPPORTED(FMT_ASSERT(false, "don't panic!"),
  ^
test/assert-test.cc:16:52: note: expanded from macro 'EXPECT_DEBUG_DEATH_IF_SUPPORTED'
    GTEST_UNSUPPORTED_DEATH_TEST(statement, regex, )
                                                   ^

With GCC 8.3:

Building CXX object test/CMakeFiles/assert-test.dir/assert-test.cc.o
FAILED: test/CMakeFiles/assert-test.dir/assert-test.cc.o
/usr/local/bin/g++8  -DFMT_USE_FILE_DESCRIPTORS=1 -DGTEST_HAS_STD_WSTRING=1 -D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING=1 -Iinclude -isystem test/gtest -isystem test/gmock -isystem test/. -O3 -DNDEBUG   -fno-delete-null-pointer-checks -std=gnu++11 -MD -MT test/CMakeFiles/assert-test.dir/assert-test.cc.o -MF test/CMakeFiles/assert-test.dir/assert-test.cc.o.d -o test/CMakeFiles/assert-test.dir/assert-test.cc.o -c test/assert-test.cc
test/assert-test.cc: In member function 'virtual void AssertTest_Fail_Test::TestBody()':
test/assert-test.cc:16:52: error: expected primary-expression before ')' token
     GTEST_UNSUPPORTED_DEATH_TEST(statement, regex, )
                                                    ^
test/assert-test.cc:20:3: note: in expansion of macro 'EXPECT_DEBUG_DEATH_IF_SUPPORTED'
   EXPECT_DEBUG_DEATH_IF_SUPPORTED(FMT_ASSERT(false, "don't panic!"),
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
test/assert-test.cc:16:5: error: 'GTEST_UNSUPPORTED_DEATH_TEST' was not declared in this scope
     GTEST_UNSUPPORTED_DEATH_TEST(statement, regex, )
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
test/assert-test.cc:20:3: note: in expansion of macro 'EXPECT_DEBUG_DEATH_IF_SUPPORTED'
   EXPECT_DEBUG_DEATH_IF_SUPPORTED(FMT_ASSERT(false, "don't panic!"),
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
test/assert-test.cc:16:5: note: suggested alternative: 'GTEST_UNSUPPORTED_DEATH_TEST_'
     GTEST_UNSUPPORTED_DEATH_TEST(statement, regex, )
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
test/assert-test.cc:20:3: note: in expansion of macro 'EXPECT_DEBUG_DEATH_IF_SUPPORTED'
   EXPECT_DEBUG_DEATH_IF_SUPPORTED(FMT_ASSERT(false, "don't panic!"),
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

[vitaut]

Yeah, this looks wrong. GTEST_UNSUPPORTED_DEATH_TEST should just be replaced with printing a warning that death tests are not supported.

[vitaut]

Should be fixed in bc628f8. Thanks for reporting.

[jackyf]

Intesting. In the version of GTest we have in Debian, it's the opposite (the macro is provided without a trailing underscore).

[vitaut]

@jackyf, I replaced use of the internal macro with printing a warning if debug tests are not supported: 13d82e3.

[jackyf]

@vitaut: Thanks, it will allow us to drop the local patch.