Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fmt::v6::internal::fallback_format multiply defined Visual Studio 2017 #1306

Closed
bowie7070 opened this issue Sep 10, 2019 · 2 comments
Closed

Comments

@bowie7070
Copy link

bowie7070 commented Sep 10, 2019

First off, thanks for the great library. It is such an improvement over the type unsafe sprintf/print.

I have a project that was compiling and linking under both clang/linux and Visual Studio/win32. I am now getting errors from Visual Studio while linking:

1>test-cases.obj : error LNK2005: "void __cdecl fmt::v6::internal::fallback_format(class fmt::v6::internal::fp const &,int)" (?fallback_format@internal@v6@fmt@@YAXABVfp@123@H@Z) already defined in test-cases-2fx.obj
1>C:\Users\owe043\Documents\svn-RiskLab\Containers\trunk\Release\catch-gen-MC.exe : fatal error LNK1169: one or more multiply defined symbols found

I have tried to bisect the problem and I have that commit 6649b8e is good (I'm consuming via svn so this is what they look like to me):

5594 | victor.zverovich | 2019-09-08 07:23:19 +1000 (Sun, 08 Sep 2019) | 2 lines

value -> bigit

The next commit ac71d85 doesn't compile for me:

r5595 | victor.zverovich | 2019-09-08 10:28:59 +1000 (Sun, 08 Sep 2019) | 2 lines

Refactor normalize and clean up

The next commit 0887887 is the first bad commit:

r5596 | victor.zverovich | 2019-09-08 11:10:36 +1000 (Sun, 08 Sep 2019) | 2 lines

Implement left shift

vitaut added a commit that referenced this issue Sep 10, 2019
@vitaut
Copy link
Contributor

vitaut commented Sep 10, 2019

Should be fixed in c6d1a94. Thanks for reporting!

@vitaut vitaut closed this as completed Sep 10, 2019
@bowie7070
Copy link
Author

Can confirm that resolves the problem for me.

Happy to help. Thanks for fixing it so quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants