Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enum class is treated as int under gcc/clang #1424

Closed
ShaderManager opened this issue Nov 27, 2019 · 4 comments
Closed

enum class is treated as int under gcc/clang #1424

ShaderManager opened this issue Nov 27, 2019 · 4 comments

Comments

@ShaderManager
Copy link

https://godbolt.org/z/VZUd--

fmtlib v6.0.0:
fmtlib under clang/gcc formats enum class as int when there is no overloaded operator << for this type. MSVC emits error don't know how to format the type
fmtlib v5.3.0:
all major compilers (clang, gcc, msvc) emit error don't know how to format the type

Is there some regression between v5.3.0 and v6.0.0 related to this issue?
@vitaut
Copy link
Contributor

vitaut commented Nov 27, 2019

Good catch. Looks like regression was introduced in #1286. A cast should be replaced with an implicit conversion.

vitaut added a commit that referenced this issue Nov 27, 2019
@vitaut
Don't implicitly convert enum to the underlying type (#1424)
70b951f
vitaut added a commit that referenced this issue Nov 27, 2019
@vitaut
Don't implicitly convert enum to the underlying type (#1424)
9a37d5f
@vitaut
Copy link
Contributor

vitaut commented Nov 27, 2019

Should be fixed in 9a37d5f.

@vitaut vitaut closed this as completed Nov 27, 2019
@vitaut vitaut mentioned this issue Nov 25, 2021
Closed
@vitaut vitaut reopened this Nov 25, 2021
@vitaut
Copy link
Contributor

vitaut commented Nov 25, 2021

Looks like there was a regression.

@vitaut
Copy link
Contributor

vitaut commented Dec 9, 2021

The regression has been fixed in fd62fba.

@vitaut vitaut closed this as completed Dec 9, 2021
@vitaut vitaut mentioned this issue Jan 7, 2022
Closed
alandtse added a commit to alandtse/BaseObjectSwapper that referenced this issue Jan 31, 2022
@alandtse
Fix fmt no longer allowing enum implicit casting
167bcbc 
See fmtlib/fmt#1424
nlimpert added a commit to nlimpert/gazebo-rcll that referenced this issue Apr 9, 2022
@nlimpert
plugins/mps: add operator<< for enums for fmt ostream support
6e6d756 
fmt versions >= 8.1.0 [does not support enum interpretation as
int](fmtlib/fmt#1424) anymore which requires
the definition of ostream::operator<< accordingly.
@nlimpert nlimpert mentioned this issue Apr 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vitaut @ShaderManager