Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PGI compiler does not handle FMT_FALLTHROUGH correctly #1583

Closed
federico-busato opened this issue Mar 9, 2020 · 1 comment
Closed

PGI compiler does not handle FMT_FALLTHROUGH correctly #1583

federico-busato opened this issue Mar 9, 2020 · 1 comment

Comments

@federico-busato
Copy link
Contributor

The PGI compiler can set FMT_GCC_VERSION >= 700, but it does not recognize gnu::fallthrough
error:
fmt/format.h", line 1268: error #1097: unknown attribute "gnu::fallthrough"

Possible fix:

#  elif FMT_GCC_VERSION >= 700 && !defined(__PGI)
#    define FMT_FALLTHROUGH [[gnu::fallthrough]]

Tested with PGI 20.1
vitaut added a commit that referenced this issue Mar 11, 2020
@vitaut
Workaround broken fallthrough attribute in the PGI compiler (#1583)
941d5e1
@vitaut
Copy link
Contributor

vitaut commented Mar 11, 2020

Applied the suggested fix in 941d5e1. Thanks!

@vitaut vitaut closed this as completed Mar 11, 2020
teajay-fr pushed a commit to teajay-fr/fmt that referenced this issue Mar 18, 2020
@vitaut
Workaround broken fallthrough attribute in the PGI compiler (fmtlib#1583
a3d8035 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vitaut @federico-busato