Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PGI 19 doesn't support UDL Templates #1811

Closed
n16h7hunt3r opened this issue Aug 11, 2020 · 1 comment
Closed

PGI 19 doesn't support UDL Templates #1811

n16h7hunt3r opened this issue Aug 11, 2020 · 1 comment

Comments

@n16h7hunt3r
Copy link
Contributor

While compiling in an an other project i got this error message

"fmt/bundled/format.h", line 3455:
          error: a literal operator template must have a template parameter
          list equivalent to "<char ...>"
  FMT_CONSTEXPR internal::udl_formatter<Char, CHARS...> operator""_format() {
                                                        ^

1 error detected in the compilation of "/host_pwd/src/adaption/Adaption.cpp".

using

-- Using PGI 19.10.0
-- Release flags:  -std=c++17 -Mnollvm -std=c++17 ,  -fast -O3 -DNDEBUG -O3 -fast -w -DNDEBUG
-- 
-- Platform: 
--     Host: Linux4.9.232x86_64
--     CMake: 3.10.2
--     CMake generator: Unix Makefiles
--     CMake build tool: /usr/bin/make
--     Configuration: Release

can be fixed by setting # define FMT_UDL_TEMPLATE 0 if you are using PGI

n16h7hunt3r pushed a commit to FireDynamics/ARTSS that referenced this issue Aug 11, 2020
@vitaut
Copy link
Contributor

vitaut commented Aug 11, 2020

Could you submit a PR disabling FMT_UDL_TEMPLATE for PGI in

fmt/include/fmt/format.h

Lines 144 to 151 in 54daa08

# if FMT_USE_USER_DEFINED_LITERALS && \
(!defined(__EDG_VERSION__) || __EDG_VERSION__ >= 501) && \
((FMT_GCC_VERSION >= 604 && __cplusplus >= 201402L) || \
FMT_CLANG_VERSION >= 304)
# define FMT_USE_UDL_TEMPLATE 1
# else
# define FMT_USE_UDL_TEMPLATE 0
# endif
since you are in the best position to test the change?

vitaut pushed a commit that referenced this issue Aug 11, 2020
* fix: disabled UDL templates for PGI (#1811)

* fix: insert defined auround __PGI

Co-authored-by: n16h7hunt3r <n16h7hunt3r@nixos>
@vitaut vitaut closed this as completed Aug 11, 2020
@vitaut vitaut changed the title PGI 19 dosn't support UDL Templates PGI 19 doesn't support UDL Templates Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants