Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Posibility to misinterpret wide characters in more parts of the format string #1932

Closed
barcharcraz opened this issue Oct 12, 2020 · 2 comments
Closed

Posibility to misinterpret wide characters in more parts of the format string #1932

barcharcraz opened this issue Oct 12, 2020 · 2 comments

Comments

@barcharcraz
Copy link
Contributor

fmt/include/fmt/format.h

Line 2834 in af28305

switch (static_cast<char>(*begin)) {

I believe this static cast should not exist, I found in our supported frontends we could get away with just no cast here, and let the case labels widen on their own, you may have to support compilers/warning levels that warn there.

Similar to #1870
@vitaut
Copy link
Contributor

vitaut commented Oct 12, 2020

Right. A PR is welcome.

vitaut added a commit that referenced this issue Oct 17, 2020
@vitaut
Fix handling of weird character types when parsing sign (#1932)
4e78699
vitaut added a commit that referenced this issue Oct 17, 2020
@vitaut
Fix handling of weird character types when parsing sign (#1932)
20d4f2e
@vitaut
Copy link
Contributor

vitaut commented Oct 17, 2020

Fixed in 20d4f2e. Thanks for reporting.

@vitaut vitaut closed this as completed Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vitaut @barcharcraz