Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lot of warnings with -Weverything flag #250

Closed
3Hren opened this issue Dec 20, 2015 · 3 comments
Closed

Lot of warnings with -Weverything flag #250

3Hren opened this issue Dec 20, 2015 · 3 comments

Comments

@3Hren
Copy link

3Hren commented Dec 20, 2015

Hi!

Compiling with -Weverything produces a lot of warnings. Half of them are -Wsign-conversion, some -Wswitch-enum, some -Wunused-member-function.

Either I can try to fix it myself or to enclose them with pragmas or to wait for your participation.

@vitaut
Copy link
Contributor

vitaut commented Dec 21, 2015

Hello!
Are you talking about Clang's -Weverything? If it enables all warnings this will probably give lots of false positives (warnings with lower rates of false positives included in -Wall and -Wextra should be addressed already). That said, PRs that fix or suppress these warnings are welcome.

@vitaut
Copy link
Contributor

vitaut commented Mar 2, 2016

Sign conversion warnings should be fixed now (#281).

vitaut added a commit that referenced this issue May 10, 2016
vitaut added a commit that referenced this issue May 10, 2016
vitaut added a commit that referenced this issue May 26, 2016
vitaut added a commit that referenced this issue May 26, 2016
vitaut added a commit that referenced this issue May 26, 2016
@vitaut
Copy link
Contributor

vitaut commented Jun 15, 2016

format.h is warning-free as of a201c61. However, -Weverything has too much noise, so warnings elsewhere, if any, better be addressed case-by-case.

@vitaut vitaut closed this as completed Jun 15, 2016
foonathan pushed a commit that referenced this issue Oct 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants