Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tuple-formatter doesn't check that the tuple-elements are formattable. #2939

Closed
jehelset opened this issue Jun 13, 2022 · 1 comment · Fixed by #2940
Closed

tuple-formatter doesn't check that the tuple-elements are formattable. #2939

jehelset opened this issue Jun 13, 2022 · 1 comment · Fixed by #2940

Comments

@jehelset
Copy link
Contributor

tuple-formatter doesn't check that the tuple-elements are formattable:
https://github.com/fmtlib/fmt/blob/master/include/fmt/ranges.h#L285-L287

which makes is_formattable<std::tuple<T>>::value true:
https://godbolt.org/z/G3zsT4q4W

even when the T is not formattable, and trying to format std::tuple<T> will lead to a hard error.
@vitaut
Copy link
Contributor

vitaut commented Jun 16, 2022

Thanks for reporting. A PR to add such check would be welcome!

@jehelset jehelset mentioned this issue Jun 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix is_formattable for tuple-like types. jehelset/fmt
2 participants
@vitaut @jehelset